-
Notifications
You must be signed in to change notification settings - Fork 23.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Digital Ocean Block Storage Bug #41431
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
This issue/PR affects Ansible v2.7
bug
This issue/PR relates to a bug.
cloud
community_review
In order to be merged, this PR must follow the community review workflow.
digital_ocean
module
This issue/PR relates to a module.
needs_triage
Needs a first human triage before being processed.
owner_pr
This PR is made by the module's maintainer.
support:community
This issue/PR relates to code supported by the Ansible community.
labels
Jun 12, 2018
Akasurde
removed
the
needs_triage
Needs a first human triage before being processed.
label
Jun 12, 2018
following #39655 LGTM |
shipit |
pmarques
approved these changes
Jun 12, 2018
ansibot
added
automerge
This PR was automatically merged by ansibot.
shipit
This PR is ready to be merged by Core
and removed
community_review
In order to be merged, this PR must follow the community review workflow.
labels
Jun 12, 2018
@BondAnthony Thanks for the PR. @pmarques Thanks for the review. |
@Akasurde could you back port this change? |
Akasurde
pushed a commit
to Akasurde/ansible
that referenced
this pull request
Jun 12, 2018
Fix added for Digital Ocean Volumes API change causing Ansible to recieve an unexpected value in the response. Signed-off-by: ABond <ajbond2005@gmail.com> Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com> (cherry picked from commit 4efe53e)
@BondAnthony Backport for Stable-2.6 #41440 |
mattclay
pushed a commit
that referenced
this pull request
Jun 12, 2018
Fix added for Digital Ocean Volumes API change causing Ansible to recieve an unexpected value in the response. Signed-off-by: ABond <ajbond2005@gmail.com> Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com> (cherry picked from commit 4efe53e)
jacum
pushed a commit
to jacum/ansible
that referenced
this pull request
Jun 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.7
This issue/PR affects Ansible v2.7
automerge
This PR was automatically merged by ansibot.
bug
This issue/PR relates to a bug.
cloud
digital_ocean
module
This issue/PR relates to a module.
owner_pr
This PR is made by the module's maintainer.
shipit
This PR is ready to be merged by Core
support:community
This issue/PR relates to code supported by the Ansible community.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Digital Ocean Volumes API changed causing Ansible to recieve an unexpected value in the response. This resulted in Ansible not being able to validate the state of existing volumes.
This resolves #39655 by changing the ID to conflict.
ISSUE TYPE
COMPONENT NAME
lib/ansible/modules/cloud/digital_ocean/digital_ocean_block_storage.py
ANSIBLE VERSION