Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meraki modules - Remove notes from modules #41614

Merged
merged 1 commit into from
Jun 20, 2018
Merged

Meraki modules - Remove notes from modules #41614

merged 1 commit into from
Jun 20, 2018

Conversation

kbreit
Copy link
Contributor

@kbreit kbreit commented Jun 16, 2018 •
edited

SUMMARY

Notes for Meraki modules were duplicated since it's in the fragment and modules. This removes the code from the modules.

Fixes #41591

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

meraki_snmp
meraki_organization
meraki_network
meraki_admin

@ansibot
Copy link
Contributor

ansibot commented Jun 16, 2018

cc @dagwieers
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. meraki Cisco Meraki community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Jun 16, 2018
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Jun 16, 2018
@beeankha
Copy link
Contributor

Hey @kbreit , thanks for submitting this PR! We'll be taking a look as soon as we get a chance, and will update with a comment once we're done testing.

dagwieers
dagwieers approved these changes Jun 20, 2018
View reviewed changes
Copy link
Contributor

@dagwieers dagwieers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dagwieers dagwieers merged commit 62bad5d into ansible:devel Jun 20, 2018
@kbreit kbreit mentioned this pull request Jun 20, 2018
Merged
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@kbreit
Remove notes since it's already specified in the doc fragment (ansibl…
93ea012 
…e#41614)
@kbreit kbreit deleted the meraki/bug-41591 branch September 28, 2018 16:01
@dagwieers dagwieers added the cisco Cisco technologies label Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Jun 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dagwieers dagwieers dagwieers approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. meraki Cisco Meraki community module This issue/PR relates to a module. networking Network category owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meraki documentation notes are duplicated
5 participants
@kbreit @ansibot @beeankha @dagwieers @Akasurde