Use inventory.get_host instead of direct access to inventory.hosts #41860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
s-hertel
removed
the
needs_triage
s-hertel
approved these changes
Jun 22, 2018
…ectly instead of get_host
ansibot
added
needs_revision
sivel
added a commit
to sivel/ansible
that referenced
this pull request
Jun 25, 2018
…nsible#41860) * Use inventory.get_host instead of direct access to inventory.hosts. Fixes ansible#32152 * Prevent potential side effect, by using self._inventory.localhost directly instead of get_host (cherry picked from commit 1a2ef09)
sivel
added a commit
to sivel/ansible
that referenced
this pull request
Jun 25, 2018
sivel
added a commit
to sivel/ansible
that referenced
this pull request
Jun 25, 2018
…nsible#41860) * Use inventory.get_host instead of direct access to inventory.hosts. Fixes ansible#32152 * Prevent potential side effect, by using self._inventory.localhost directly instead of get_host (cherry picked from commit 1a2ef09)
sivel
added a commit
to sivel/ansible
that referenced
this pull request
Jun 25, 2018
This was referenced Jun 25, 2018
jacum
pushed a commit
to jacum/ansible
that referenced
this pull request
Jun 26, 2018
…nsible#41860) * Use inventory.get_host instead of direct access to inventory.hosts. Fixes ansible#32152 * Prevent potential side effect, by using self._inventory.localhost directly instead of get_host
mattclay
pushed a commit
that referenced
this pull request
Jun 26, 2018
…41927) * Use inventory.get_host instead of direct access to inventory.hosts (#41860) * Use inventory.get_host instead of direct access to inventory.hosts. Fixes #32152 * Prevent potential side effect, by using self._inventory.localhost directly instead of get_host (cherry picked from commit 1a2ef09) * Add changelog for #41860
kbreit
pushed a commit
to kbreit/ansible
that referenced
this pull request
Jul 3, 2018
…host (ansible#41927) * Use inventory.get_host instead of direct access to inventory.hosts (ansible#41860) * Use inventory.get_host instead of direct access to inventory.hosts. Fixes ansible#32152 * Prevent potential side effect, by using self._inventory.localhost directly instead of get_host (cherry picked from commit 1a2ef09) * Add changelog for ansible#41860
nitzmahone
pushed a commit
that referenced
this pull request
Jul 3, 2018
…41926) * Use inventory.get_host instead of direct access to inventory.hosts (#41860) * Use inventory.get_host instead of direct access to inventory.hosts. Fixes #32152 * Prevent potential side effect, by using self._inventory.localhost directly instead of get_host (cherry picked from commit 1a2ef09) * Add changelog for #41860
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Use
inventory.get_hostinstead of direct access toinventory.hosts. Fixes #32152This allows
group_byto work with implicit localhost.ISSUE TYPE
COMPONENT NAME
lib/ansible/plugins/strategy/init.py
ANSIBLE VERSION
ADDITIONAL INFORMATION