Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use inventory.get_host instead of direct access to inventory.hosts #41860

Merged
merged 2 commits into from
Jun 25, 2018
Merged

Use inventory.get_host instead of direct access to inventory.hosts #41860

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a3fd9c
Use inventory.get_host instead of direct access to inventory.hosts. F…
sivel Jun 22, 2018
7eb80da
Prevent potential side effect, by using self._inventory.localhost dir…
sivel Jun 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/ansible/plugins/strategy/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,12 @@ def _add_group(self, host, result_item):
# the host here is from the executor side, which means it was a
# serialized/cloned copy and we'll need to look up the proper
# host object from the master inventory
real_host = self._inventory.hosts[host.name]
real_host = self._inventory.hosts.get(host.name)
if real_host is None:
if host.name == self._inventory.localhost.name:
real_host = self._inventory.localhost
else:
raise AnsibleError('%s cannot be matched in inventory' % host.name)
group_name = result_item.get('add_group')
parent_group_names = result_item.get('parent_groups', [])

Expand Down