Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vultr: Introducing vultr_block_storage module #43202

Merged
merged 1 commit into from
Aug 17, 2018
Merged

Vultr: Introducing vultr_block_storage module #43202

merged 1 commit into from
Aug 17, 2018

Conversation

Spredzy
Copy link
Contributor

@Spredzy Spredzy commented Jul 24, 2018 •
edited

SUMMARY

This commit introduces a new module called vultr_block_storage

It allows a user to manage block storage volumes on the Vultr cloud.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • vultr_block_storage
ANSIBLE VERSION
  • devel
ADDITIONAL INFORMATION
  • N/A

@ansibot
Copy link
Contributor

ansibot commented Jul 24, 2018

cc @resmo
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 24, 2018
@maxamillion maxamillion removed the needs_triage Needs a first human triage before being processed. label Jul 24, 2018
@Spredzy Spredzy mentioned this pull request Jul 24, 2018
Merged
@Spredzy Spredzy force-pushed the vr_block_storage branch 2 times, most recently from f2da9f3 to 6a3ecfe Compare August 3, 2018 07:42
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 11, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 13, 2018
@resmo resmo mentioned this pull request Aug 15, 2018
Closed
@resmo
Copy link
Contributor

resmo commented Aug 15, 2018

closes #44232

resmo
resmo reviewed Aug 16, 2018
View reviewed changes
lib/ansible/modules/cloud/vultr/vultr_block_storage.py Outdated
'SUBID': dict(key='id'),
'label': dict(key='name'),
'DCID': dict(key='region', transform=self._get_region_name),
'attached_to_SUBID': dict(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

following our naming, this would be attached_to_id. Any concerns changing this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@Spredzy Spredzy changed the title Vultr: Introducing vr_block_storage module Vultr: Introducing vultr_block_storage module Aug 16, 2018
@Spredzy Spredzy force-pushed the vr_block_storage branch 2 times, most recently from 39b2e7a to c89d389 Compare August 16, 2018 08:11
@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2018

@Spredzy this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 16, 2018
resmo
resmo reviewed Aug 16, 2018
View reviewed changes
lib/ansible/modules/cloud/vultr/vultr_block_storage.py Outdated
'attached_to_SUBID': dict(key='attached_to_id'),
'cost_per_month': dict(convert_to='float'),
'date_created': dict(),
'id': dict(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this by mistake? 2 times key id: subid and id?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, mistake. Fixed.

@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Aug 16, 2018
@Spredzy
Vultr: Introducing vultrr_block_storage module
a004cbb 
This commit introduces a new module called vultr_block_storage/

It allows a user to manage block storage volumes on the Vultr cloud.
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 17, 2018
resmo
resmo approved these changes Aug 17, 2018
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@resmo resmo merged commit 57497a4 into ansible:devel Aug 17, 2018
@dagwieers dagwieers added the vultr Vultr community label Feb 11, 2019
@willthames willthames mentioned this pull request May 1, 2019
Merged
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. vultr Vultr community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Spredzy @ansibot @resmo @dagwieers @maxamillion