adding container registry facts #43325

zikalino · 2018-07-26T20:57:16Z

SUMMARY

Creating missing container registry facts.

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

azure_rm_containerregistry_facts

ANSIBLE VERSION

2.6

ADDITIONAL INFORMATION

ansibot · 2018-07-26T21:01:47Z

Hi @zikalino,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

Fred-sun · 2018-08-15T06:00:47Z

@zikalino Could you help to confirm the PR ready for review or not? Thanks!

Fred-sun · 2018-08-28T08:14:23Z

@zikalino Could you help to confirm the PR ready for review or not? Thanks!

ansibot · 2018-08-28T08:21:48Z

cc @haroldwongms @nitzmahone @trstringer @xscript @yuwzho
click here for bot help

zikalino · 2018-08-29T01:01:50Z

@Fred-sun this PR has label WIP which means that it's not ready for review

Fred-sun · 2018-08-29T01:26:48Z

@zikalino I'm sorry, The PR have no update more than one week, So I update the comment to understand the PR status. Thanks!

yuwzho · 2018-08-29T02:05:19Z

lib/ansible/modules/cloud/azure/azure_rm_containerregistry_facts.py

+    description: A list of dict results where the key is the name of the Registry and the values are the facts for that Registry.
+    returned: always
+    type: complex
+    contains:


Can we show username/password, webhook list, registry list, registry tag list and buildtask list in the facts?

ansibot · 2018-08-29T02:08:14Z

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_containerregistry_facts.py:197:1: E305 expected 2 blank lines after class or function definition, found 0

click here for bot help

ansibot · 2018-08-29T02:31:26Z

cc @yaweiw
click here for bot help

ansibot · 2018-08-29T02:48:51Z

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_containerregistry_facts.py:197:1: E305 expected 2 blank lines after class or function definition, found 0

click here for bot help

yungezz · 2018-08-29T08:31:36Z

lib/ansible/modules/cloud/azure/azure_rm_containerregistry_facts.py

+    pass
+
+
+class AzureRMRegistryFacts(AzureRMModuleBase):


AzureRMContainerRegistryFacts

ansibot · 2018-08-29T08:50:17Z

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/azure/azure_rm_containerregistry_facts.py:224:120: E241 multiple spaces after ','
lib/ansible/modules/cloud/azure/azure_rm_containerregistry_facts.py:224:161: E501 line too long (219 > 160 characters)

click here for bot help

ansibot · 2018-08-29T09:18:22Z

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

lib/ansible/modules/cloud/azure/azure_rm_containerregistry_facts.py:228:24: E201 whitespace after '{'
lib/ansible/modules/cloud/azure/azure_rm_containerregistry_facts.py:230:120: E241 multiple spaces after ','
lib/ansible/modules/cloud/azure/azure_rm_containerregistry_facts.py:230:161: E501 line too long (219 > 160 characters)
lib/ansible/modules/cloud/azure/azure_rm_containerregistry_facts.py:244:26: E203 whitespace before ':'

click here for bot help

ansibot · 2018-08-29T09:39:16Z

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/azure/azure_rm_containerregistry_facts.py:228:24: E201 whitespace after '{'
lib/ansible/modules/cloud/azure/azure_rm_containerregistry_facts.py:244:26: E203 whitespace before ':'

click here for bot help

zikalino · 2018-08-29T11:18:14Z

@yungezz returning credentials follows azure_rm_containerregistry

yungezz · 2018-08-30T04:47:14Z

lib/ansible/modules/cloud/azure/azure_rm_containerregistry_facts.py

+        credentials:
+            description:
+                - Credentials, fields will be empty if admin user is not enabled for ACR
+            return: always


return is not always, but when retrieve option is on

yungezz · 2018-08-30T04:53:06Z

lib/ansible/modules/cloud/azure/azure_rm_containerregistry_facts.py

+                    returned: when registry exists and C(admin_user_enabled) is set
+                    type: str
+                    sample: zim
+                password:


jordan mentioned to add no_log to returned value this morning. do you know how to add it?

not really, we can search... but I guess I we have option to specifically enable passwords, we can skip it for now

don't think so. the option is weak, just make it little difficult to get credential. no_log is really make it not available in another other place other than ansible

@yungezz no_log can be placed in the playbook, we do not have to do anything in the module itself

yungezz · 2018-08-30T09:48:50Z

lib/ansible/modules/cloud/azure/azure_rm_containerregistry_facts.py

+        credentials:
+            description:
+                - Credentials, fields will be empty if admin user is not enabled for ACR
+            return: when C(retrieve_credentials) is set and C(admin_user_enabled) is set on ACR


returned :( will lint fail?

ok, I will recheck this once again

adding container registry facts

37950fd

ansibleazurebot mentioned this pull request Jul 27, 2018

adding container registry facts VSChina/ansible-issue-tracker#359

Closed

s-hertel removed the needs_triage Needs a first human triage before being processed. label Jul 27, 2018

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 4, 2018

updated container registry facts

86d5d77

ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 29, 2018

yuwzho reviewed Aug 29, 2018

View reviewed changes

ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Aug 29, 2018

updated facts for container registry

004c848

ansibot added test This PR relates to tests. and removed ci_verified Changes made in this PR are causing tests to fail. labels Aug 29, 2018

fix test

bba91d0

ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Aug 29, 2018

fixed comments

e72712d

yungezz reviewed Aug 29, 2018

View reviewed changes

fix

3018940

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 29, 2018

credentials fix

bfc6c1b

zikalino added 2 commits August 29, 2018 17:19

fix syntax

01744ed

stupid syntax mistake

a4e87b5

zikalino added 4 commits August 29, 2018 18:47

fix credentials issue

e10bf65

change test as now can't test facts properly

d24fbcf

updated returned value for credentials

9e90709

fixed name

080dbf9

ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 29, 2018

added option to retrieve credentials

ce3b249

yungezz reviewed Aug 30, 2018

View reviewed changes

update documentation

c1e2b9c

yungezz reviewed Aug 30, 2018

View reviewed changes

yungezz approved these changes Aug 30, 2018

View reviewed changes

yungezz merged commit bd866ed into ansible:devel Aug 30, 2018

yungezz deleted the facts-containerregistry branch August 30, 2018 09:56

ansible locked and limited conversation to collaborators Jul 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding container registry facts #43325

adding container registry facts #43325

zikalino commented Jul 26, 2018

ansibot commented Jul 26, 2018

Fred-sun commented Aug 15, 2018

Fred-sun commented Aug 28, 2018

ansibot commented Aug 28, 2018

zikalino commented Aug 29, 2018

Fred-sun commented Aug 29, 2018

yuwzho Aug 29, 2018

ansibot commented Aug 29, 2018

ansibot commented Aug 29, 2018

ansibot commented Aug 29, 2018

yungezz Aug 29, 2018

ansibot commented Aug 29, 2018

ansibot commented Aug 29, 2018

ansibot commented Aug 29, 2018

zikalino commented Aug 29, 2018

yungezz Aug 30, 2018

yungezz Aug 30, 2018

zikalino Aug 30, 2018

yungezz Aug 30, 2018

zikalino Aug 30, 2018

yungezz Aug 30, 2018

zikalino Aug 30, 2018

adding container registry facts #43325

adding container registry facts #43325

Conversation

zikalino commented Jul 26, 2018

SUMMARY

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

ADDITIONAL INFORMATION

ansibot commented Jul 26, 2018

Fred-sun commented Aug 15, 2018

Fred-sun commented Aug 28, 2018

ansibot commented Aug 28, 2018

zikalino commented Aug 29, 2018

Fred-sun commented Aug 29, 2018

Choose a reason for hiding this comment

ansibot commented Aug 29, 2018

ansibot commented Aug 29, 2018

ansibot commented Aug 29, 2018

Choose a reason for hiding this comment

ansibot commented Aug 29, 2018

ansibot commented Aug 29, 2018

ansibot commented Aug 29, 2018

zikalino commented Aug 29, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment