ec2_ami_facts should take nonstrings as filter arguments

[tedder]

SUMMARY

Booleans or numbers passed to most AWS APIs need to be cast to strings or they die. (this might be better fixed in ansible_dict_to_boto3_filter_list than in _facts)

ISSUE TYPE

• Bug Report

COMPONENT NAME

ec2_ami_facts

ANSIBLE VERSION

2.6.0

CONFIGURATION

not relevant

OS / ENVIRONMENT

not relevant

STEPS TO REPRODUCE

- name: find
  ec2_ami_facts:
    region: "{{region}}"
    filters:
      architecture: x86_64
      is-public: true
      name: "amzn-ami-2018.03.c-amazon-ecs-optimized"
      owner-id: 591542846629 # amazon's id

The second and fourth lines are 'bad'- one is a number, one is a bool, both fail.

EXPECTED RESULTS

results to be returned.
I expected it to work.

ACTUAL RESULTS

It died.

An exception occurred during task execution. To see the full traceback, use -vvv. The error was: Invalid type for parameter Filters[2].Values, value: True, type: <class 'bool'>, valid types: <class 'list'>, <class 'tuple'>
fatal: [localhost]: FAILED! => {"changed": false, "msg": "error describing images: Parameter validation failed:\nInvalid type for parameter Filters[1].Values, value: 591542846629, type: <class 'int'>, valid types: <class 'list'>, <class 'tuple'>\nInvalid type for parameter Filters[2].Values, value: True, type: <class 'bool'>, valid types: <class 'list'>, <class 'tuple'>"}

(after fixing the bool)

An exception occurred during task execution. To see the full traceback, use -vvv. The error was: Invalid type for parameter Filters[6].Values, value: 591542846629, type: <class 'int'>, valid types: <class 'list'>, <class 'tuple'>
fatal: [localhost]: FAILED! => {"changed": false, "msg": "error describing images: Parameter validation failed:\nInvalid type for parameter Filters[6].Values, value: 591542846629, type: <class 'int'>, valid types: <class 'list'>, <class 'tuple'>"}

[ansibot]

Files identified in the description:

• lib/ansible/modules/cloud/amazon/ec2_ami_facts.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibot]

cc @prasadkatti
click here for bot help

[ansibot]

Hi @tedder,

Thank you for the issue, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

[san7ket]

@tedder Can you verify if the fix works for you?

[tedder]

yep, that fixes it for me!