add azure_rm_webapp_facts module #43631

yungezz · 2018-08-03T09:01:58Z

SUMMARY

add azure_rm_webapp_facts module

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

azure_rm_webapp_facts

ANSIBLE VERSION

ansible 2.7

ADDITIONAL INFORMATION

ansibot · 2018-08-03T09:06:27Z

Hi @yungezz,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

ansibot · 2018-08-03T09:16:24Z

The test ansible-test sanity --test pylint [explain] failed with 4 errors:

lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:299:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:315:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:326:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:338:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 8 errors:

lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:42:19: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:236:52: E127 continuation line over-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:237:52: E127 continuation line over-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:299:23: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:315:23: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:326:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:338:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:343:1: E303 too many blank lines (3)

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:172:52: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:172:52: error RETURN: syntax error: found unknown escape character 'w'

click here for bot help

Fred-sun · 2018-08-10T16:44:21Z

@zikalino The PR has ready for revew. Could you help to take a look? Thanks!

ansibot · 2018-08-13T02:20:37Z

The test ansible-test sanity --test pylint [explain] failed with 4 errors:

lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:299:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:315:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:326:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:338:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 8 errors:

lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:42:19: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:236:52: E127 continuation line over-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:237:52: E127 continuation line over-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:299:23: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:315:23: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:326:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:338:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:343:1: E303 too many blank lines (3)

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:172:52: error RETURN: syntax error: found unknown escape character 'w'

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:172:52: E313 RETURN is not valid YAML

click here for bot help

Fred-sun · 2018-08-14T08:48:36Z

@yungezz Please help confirm, does this PR ready for review?

zikalino · 2018-08-15T04:32:29Z

lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py

+    returned: always
+    type: list
+    example: [{
+                "app_settings": {


return value should be documented

zikalino · 2018-08-15T04:34:04Z

lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py

+                        self.results['ansible_facts']['azure_webapps'][0]['app_settings'] = self.list_webapp_appsettings()
+
+        elif self.resource_group:
+            self.results['ansible_facts']['azure_webapps'] = self.list_by_resource_group()


recently the idea is not to place facts inside 'ansible_facts'

then where to put it? has the idea been agreed?

yes, even mentioned today on the meeting...
also I would rename 'azure_webapps' to just 'webapps', as azure part is a kind of obvious

ansibot · 2018-08-15T04:43:25Z

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:280:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 6 errors:

lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:173:27: E222 multiple spaces after operator
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:197:31: E222 multiple spaces after operator
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:214:31: E222 multiple spaces after operator
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:273:58: E201 whitespace after '{'
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:273:100: E202 whitespace before '}'
lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:280:1: W293 blank line contains whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:69:7: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:69:7: error RETURN: syntax error: expected the node content, but found '-'

click here for bot help

zikalino · 2018-08-15T04:48:49Z

lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py

+        - name: net_framework
+          version: v4.0
+        - name: node
+          versoin: '6.6'


zikalino · 2018-08-15T04:50:51Z

lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py

+
+        results = []
+        for item in response:
+            if self.has_tags(item.tags, self.tags):


there could be a function to convert entire list, as this code is repeated below

zikalino · 2018-08-15T04:55:49Z

lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py

+                    }
+                    curated_output['frameworks'].append(fx)
+
+            # java container setting


something missing here?

zikalino · 2018-08-15T12:36:56Z

lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py

+            description:
+                - Other useful properties of the web app, which is not curated to module input.
+            return: always
+            type: complex


maybe also should be described

ansibot · 2018-08-15T12:40:23Z

@brusMX @devigned @gustavomcarmo @haroldwongms @julienstroheker @lmazuel @obsoleted @sozercan @tripdubroot @trstringer @tstringer @xscript @yaweiw @yuwzho

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

zikalino · 2018-08-16T08:19:51Z

lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py

+                lastModifiedTimeUtc:
+                    description: Last modified date  of the web app.
+                    type: str
+                outboundIpAddresses:


so this is one or more addresses?

Fred-sun · 2018-08-17T08:04:27Z

@yungezz Could you help update the comment? Thanks!

ansibot · 2018-08-21T09:54:59Z

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_webapp_facts.py:273:22: too-many-format-args Too many arguments for format string

click here for bot help

Fred-sun · 2018-08-28T07:37:39Z

@zikalino Could you help re-review this PR, @yungezz has fixed the error according your comment? Thanks!

ansibot · 2018-08-28T07:42:48Z

cc @nitzmahone
click here for bot help

yungezz requested a review from zikalino August 3, 2018 09:02

mkrizek removed the needs_triage Needs a first human triage before being processed. label Aug 3, 2018

ansibleazurebot mentioned this pull request Aug 4, 2018

add azure_rm_webapp_facts module VSChina/ansible-issue-tracker#372

Closed

yungezz added 4 commits August 13, 2018 10:12

add webapp facts module

270b4bc

remove certified

7ce861e

remove useless argument

77dcd88

add tests

6dccc71

yungezz force-pushed the yungez-webappfacts branch from f357426 to 6dccc71 Compare August 13, 2018 02:12

zikalino reviewed Aug 15, 2018

View reviewed changes

return curated output

3150c1d

zikalino reviewed Aug 15, 2018

View reviewed changes

yungezz added 3 commits August 15, 2018 17:55

fix test

87a66df

fix test

0b3e15d

fix test

f149f14

zikalino reviewed Aug 15, 2018

View reviewed changes

ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 15, 2018

add properties description, refine return name

7940bf3

zikalino reviewed Aug 16, 2018

View reviewed changes

yungezz added 3 commits August 21, 2018 14:58

refine properties, add request_id when exception

5174d8c

fix bug

c3bdd05

update doc, add publish profile

789a45d

ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 21, 2018

fix error

d7d833f

ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 22, 2018

zikalino approved these changes Aug 29, 2018

View reviewed changes

flatten properties, add option for return publish profile

fc14986

zikalino approved these changes Aug 30, 2018

View reviewed changes

zikalino merged commit b731732 into ansible:devel Aug 30, 2018

zikalino deleted the yungez-webappfacts branch August 30, 2018 09:49

ansible locked and limited conversation to collaborators Jul 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add azure_rm_webapp_facts module #43631

add azure_rm_webapp_facts module #43631

yungezz commented Aug 3, 2018

ansibot commented Aug 3, 2018

ansibot commented Aug 3, 2018

Fred-sun commented Aug 10, 2018

ansibot commented Aug 13, 2018

Fred-sun commented Aug 14, 2018

zikalino Aug 15, 2018

yungezz Aug 15, 2018

zikalino Aug 15, 2018

yungezz Aug 15, 2018

zikalino Aug 16, 2018

ansibot commented Aug 15, 2018

zikalino Aug 15, 2018

yungezz Aug 15, 2018

zikalino Aug 15, 2018

yungezz Aug 15, 2018

zikalino Aug 15, 2018

yungezz Aug 15, 2018

zikalino Aug 15, 2018

ansibot commented Aug 15, 2018

zikalino Aug 16, 2018

Fred-sun commented Aug 17, 2018

ansibot commented Aug 21, 2018

Fred-sun commented Aug 28, 2018

ansibot commented Aug 28, 2018

add azure_rm_webapp_facts module #43631

add azure_rm_webapp_facts module #43631

Conversation

yungezz commented Aug 3, 2018

SUMMARY

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

ADDITIONAL INFORMATION

ansibot commented Aug 3, 2018

ansibot commented Aug 3, 2018

Fred-sun commented Aug 10, 2018

ansibot commented Aug 13, 2018

Fred-sun commented Aug 14, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ansibot commented Aug 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ansibot commented Aug 15, 2018

Choose a reason for hiding this comment

Fred-sun commented Aug 17, 2018

ansibot commented Aug 21, 2018

Fred-sun commented Aug 28, 2018

ansibot commented Aug 28, 2018