Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pick 2.6 nxos bugfixes #44105

Merged
merged 16 commits into from
Sep 4, 2018
Merged

Pick 2.6 nxos bugfixes #44105

merged 16 commits into from
Sep 4, 2018

Conversation

trishnaguha
Copy link
Member

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request

@trishnaguha
Add md5sum check in nxos_file_copy module (ansible#43423)
e5f068a 
* Add md5sum check in nxos_file_copy module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* address review comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit fee4c24)
@trishnaguha
nxos_vlan refactor to support non structured output (ansible#43805)
5cdcfa4 
* nxos_vlan refactor to support non structured output

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* unittest fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* minor fixes

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* use check_rc

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* address review comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* remove additional return statement

* address Nate's review

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 9634693)
@trishnaguha
nxos_facts test lldp feature and fix nxapi check_rc (ansible#44104)
99d3298 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 43ae240)
@trishnaguha
nxos bugfix 2.6 changelog
2d86d6c 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha
Copy link
Member Author

cc @mattclay

@trishnaguha trishnaguha added this to the 2.6.0 milestone Aug 14, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 14, 2018

cc @GGabriele @Qalthos @ganeshrn @gdpak @jedelman8 @mikewiebe @rahushen @rcarrillocruz @tstoner
click here for bot help

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Aug 14, 2018
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label Aug 14, 2018
@trishnaguha
nxos_interface port-channel idempotence fix for mode (ansible#44248)
1f5930d 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 6af6e80)
@trishnaguha
changelog
7215b05 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha
check_mode in nxos_static_route module (ansible#44252)
b2b78f4 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 7e39c5b)
@trishnaguha
changelog nxos_static_route
d7d5a46 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 16, 2018
@trishnaguha
nxos_linkagg mode fix (ansible#44294)
7cd428b 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 6090802)
@trishnaguha
changelog nxos_linkagg
9f7befe
@ansibot
Copy link
Contributor

ansibot commented Aug 25, 2018

cc @justjais
click here for bot help

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 25, 2018
@trishnaguha
nxos_system idempotence fix (ansible#44752)
2ae5e39 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 8a79d94)
@trishnaguha
nxos_system changelog
11e1a39 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha
use retry_json nxos_banner (ansible#44376)
f6b4a34 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 9c4ed4d)
@trishnaguha
nxos_banner changelog
55873af 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@ansibot
Copy link
Contributor

ansibot commented Aug 28, 2018

cc @privateip
click here for bot help

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 28, 2018
@gundalow gundalow removed this from the 2.6.0 milestone Aug 28, 2018
@trishnaguha
fix Python 2.6 regex bug terminal plugin nxos, iosxr (ansible#45135)
5c15a0a 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit ab3cd10)
@trishnaguha
terminal plugin changelog
ab0bb57 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@mattclay
Copy link
Member

mattclay commented Sep 4, 2018

@trishnaguha In the future, please open a separate PR for each backport instead of adding additional commits over time. Also, requesting a review is unnecessary as I go through all backport PRs several days before the release goes out.

@mattclay mattclay merged commit 7b840f3 into ansible:stable-2.6 Sep 4, 2018
@trishnaguha trishnaguha deleted the pick-2.6 branch September 5, 2018 04:11
@trishnaguha
Copy link
Member Author

@mattclay ack. I will keep it mind. Thanks.

@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay Awaiting requested review from mattclay

Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@trishnaguha @ansibot @mattclay @dagwieers @gundalow