fix Python 2.6 regex bug terminal plugin nxos, iosxr #45135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
ansibot
added
affects_2.8
trishnaguha
removed
the
needs_triage
ganeshrn
approved these changes
Sep 4, 2018
trishnaguha
added a commit
to trishnaguha/ansible
that referenced
this pull request
Sep 4, 2018
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit ab3cd10)
trishnaguha
added a commit
to trishnaguha/ansible
that referenced
this pull request
Sep 4, 2018
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit ab3cd10)
trishnaguha
added a commit
to trishnaguha/ansible
that referenced
this pull request
Sep 4, 2018
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit ab3cd10)
mattclay
pushed a commit
that referenced
this pull request
Sep 4, 2018
* Add md5sum check in nxos_file_copy module (#43423) * Add md5sum check in nxos_file_copy module Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * address review comment Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit fee4c24) * nxos_vlan refactor to support non structured output (#43805) * nxos_vlan refactor to support non structured output Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * unittest fix Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * minor fixes Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * use check_rc Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * address review comment Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * remove additional return statement * address Nate's review Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 9634693) * nxos_facts test lldp feature and fix nxapi check_rc (#44104) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 43ae240) * nxos bugfix 2.6 changelog Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * nxos_interface port-channel idempotence fix for mode (#44248) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 6af6e80) * changelog Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * check_mode in nxos_static_route module (#44252) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 7e39c5b) * changelog nxos_static_route Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * nxos_linkagg mode fix (#44294) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 6090802) * changelog nxos_linkagg * nxos_system idempotence fix (#44752) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 8a79d94) * nxos_system changelog Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * use retry_json nxos_banner (#44376) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 9c4ed4d) * nxos_banner changelog Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * fix Python 2.6 regex bug terminal plugin nxos, iosxr (#45135) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit ab3cd10) * terminal plugin changelog Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
nitzmahone
pushed a commit
that referenced
this pull request
Sep 5, 2018
* nxos_interface port-channel idempotence fix for mode (#44248) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 6af6e80) * changelog Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * Add md5sum check in nxos_file_copy module (#43423) * Add md5sum check in nxos_file_copy module Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * address review comment Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit fee4c24) * changelog Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * check_mode in nxos_static_route module (#44252) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 7e39c5b) * changelog nxos_static_route Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * nxos_linkagg mode fix (#44294) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 6090802) * changelog nxos_linkagg * fix Python 2.6 regex bug terminal plugin nxos, iosxr (#45135) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit ab3cd10) * terminal plugin changelog Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
abadger
pushed a commit
that referenced
this pull request
Sep 6, 2018
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit ab3cd10)
ndswartz
pushed a commit
to ndswartz/ansible
that referenced
this pull request
Nov 28, 2018
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit ab3cd10)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Trishna Guha trishnaguha17@gmail.com
SUMMARY
fixes #44894 #45171
fix Python 2.6 regex bug terminal plugin nxos, iosxr (
\ndoesn't have to be optional for nxos, iosxr)ISSUE TYPE
COMPONENT NAME
plugins/terminal/{nxos,iosxr}.py
ANSIBLE VERSION