VMware: new module vmware_dvswitch_nioc #44147

vmwjoseph · 2018-08-14T22:33:22Z

SUMMARY

Adding new modules to configure Network IO Control on DVS

vmware_dvswitch_nioc is used to enable, disable, and control the version of Network IO Control

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

vmware_dvswitch_nioc

ANSIBLE VERSION

ansible 2.6.1
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/opt/lib/ansible/modules']
  ansible python module location = /usr/lib/python2.7/dist-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.14 (default, Sep 23 2017, 22:06:14) [GCC 7.2.0]

ADDITIONAL INFORMATION

https://gitlab.eng.vmware.com/cpe-cloudops/Nova/ansible-modules/merge_requests/16
https://gitlab.eng.vmware.com/cpe-cloudops/Nova/vsphere/merge_requests/81
https://gitlab.eng.vmware.com/cpe-cloudops/Nova/core/merge_requests/32

Enable NIOC

changed: [10.161.56.129] => {
    "changed": true, 
    "invocation": {
        "module_args": {
            "hostname": "10.161.56.129", 
            "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", 
            "port": 443, 
            "resources": [
                {
                    "limit": -1, 
                    "name": "management", 
                    "reservation": 0, 
                    "shares": 10, 
                    "shares_level": "normal"
                }, 
                {
                    "limit": -1, 
                    "name": "virtualMachine", 
                    "reservation": 0, 
                    "shares": 60, 
                    "shares_level": "custom"
                }, 
                {
                    "limit": -1, 
                    "name": "vmotion", 
                    "reservation": 0, 
                    "shares": 50, 
                    "shares_level": "normal"
                }, 
                {
                    "limit": -1, 
                    "name": "vsan", 
                    "reservation": 0, 
                    "shares": 50, 
                    "shares_level": "high"
                }
            ], 
            "state": "present", 
            "switch": "nova_dvs", 
            "username": "administrator@vsphere.local", 
            "validate_certs": false, 
            "version": "version2"
        }
    }, 
    "resources_changed": [
        "management", 
        "virtualMachine"
    ], 
    "result": "Enabled NIOC with version version2"
}

Change version2 to version3

changed: [10.161.56.129] => {
    "changed": true, 
    "invocation": {
        "module_args": {
            "hostname": "10.161.56.129", 
            "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", 
            "port": 443, 
            "resources": [
                {
                    "limit": -1, 
                    "name": "management", 
                    "reservation": 0, 
                    "shares": 10, 
                    "shares_level": "normal"
                }, 
                {
                    "limit": -1, 
                    "name": "virtualMachine", 
                    "reservation": 0, 
                    "shares": 60, 
                    "shares_level": "custom"
                }, 
                {
                    "limit": -1, 
                    "name": "vmotion", 
                    "reservation": 0, 
                    "shares": 50, 
                    "shares_level": "normal"
                }, 
                {
                    "limit": -1, 
                    "name": "vsan", 
                    "reservation": 128, 
                    "shares": 50, 
                    "shares_level": "high"
                }
            ], 
            "state": "present", 
            "switch": "nova_dvs", 
            "username": "administrator@vsphere.local", 
            "validate_certs": false, 
            "version": "version3"
        }
    }, 
    "resources_changed": [
        "vsan"
    ], 
    "result": "Set NIOC to version version3"
}

Change resources

changed: [10.161.56.129] => {
    "changed": true, 
    "invocation": {
        "module_args": {
            "hostname": "10.161.56.129", 
            "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", 
            "port": 443, 
            "resources": [
                {
                    "limit": -1, 
                    "name": "management", 
                    "reservation": 0, 
                    "shares": 30, 
                    "shares_level": "custom"
                }, 
                {
                    "limit": -1, 
                    "name": "virtualMachine", 
                    "reservation": 0, 
                    "shares": 60, 
                    "shares_level": "high"
                }, 
                {
                    "limit": -1, 
                    "name": "vmotion", 
                    "reservation": 0, 
                    "shares": 50, 
                    "shares_level": "normal"
                }, 
                {
                    "limit": -1, 
                    "name": "vsan", 
                    "reservation": 100, 
                    "shares": 50, 
                    "shares_level": "high"
                }
            ], 
            "state": "present", 
            "switch": "nova_dvs", 
            "username": "administrator@vsphere.local", 
            "validate_certs": false, 
            "version": "version3"
        }
    }, 
    "resources_changed": [
        "management", 
        "virtualMachine", 
        "vsan"
    ], 
    "result": "Resource configuration modified"
}

Rerun previous (should be no chnages)

ok: [10.161.56.129] => {
    "changed": false, 
    "invocation": {
        "module_args": {
            "hostname": "10.161.56.129", 
            "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", 
            "port": 443, 
            "resources": [
                {
                    "limit": -1, 
                    "name": "management", 
                    "reservation": 0, 
                    "shares": 30, 
                    "shares_level": "custom"
                }, 
                {
                    "limit": -1, 
                    "name": "virtualMachine", 
                    "reservation": 0, 
                    "shares": 60, 
                    "shares_level": "high"
                }, 
                {
                    "limit": -1, 
                    "name": "vmotion", 
                    "reservation": 0, 
                    "shares": 50, 
                    "shares_level": "normal"
                }, 
                {
                    "limit": -1, 
                    "name": "vsan", 
                    "reservation": 100, 
                    "shares": 50, 
                    "shares_level": "high"
                }
            ], 
            "state": "present", 
            "switch": "nova_dvs", 
            "username": "administrator@vsphere.local", 
            "validate_certs": false, 
            "version": "version3"
        }
    }, 
    "resources_changed": [], 
    "result": "Unchanged"
}

Change version3 to version2

changed: [10.161.56.129] => {
    "changed": true, 
    "invocation": {
        "module_args": {
            "hostname": "10.161.56.129", 
            "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", 
            "port": 443, 
            "resources": [
                {
                    "limit": -1, 
                    "name": "management", 
                    "reservation": 0, 
                    "shares": 30, 
                    "shares_level": "custom"
                }, 
                {
                    "limit": -1, 
                    "name": "virtualMachine", 
                    "reservation": 0, 
                    "shares": 60, 
                    "shares_level": "high"
                }, 
                {
                    "limit": -1, 
                    "name": "vmotion", 
                    "reservation": 0, 
                    "shares": 50, 
                    "shares_level": "normal"
                }, 
                {
                    "limit": -1, 
                    "name": "vsan", 
                    "reservation": 100, 
                    "shares": 50, 
                    "shares_level": "high"
                }
            ], 
            "state": "present", 
            "switch": "nova_dvs", 
            "username": "administrator@vsphere.local", 
            "validate_certs": false, 
            "version": "version2"
        }
    }, 
    "resources_changed": [
        "management", 
        "vsan"
    ], 
    "result": "Set NIOC to version version2"
}

Disable NIOC

changed: [10.161.56.129] => {
    "changed": true, 
    "invocation": {
        "module_args": {
            "hostname": "10.161.56.129", 
            "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", 
            "port": 443, 
            "resources": [
                {
                    "limit": -1, 
                    "name": "management", 
                    "reservation": 100, 
                    "shares": 10, 
                    "shares_level": "high"
                }, 
                {
                    "limit": -1, 
                    "name": "virtualMachine", 
                    "reservation": 0, 
                    "shares": 30, 
                    "shares_level": "custom"
                }, 
                {
                    "limit": -1, 
                    "name": "vmotion", 
                    "reservation": 0, 
                    "shares": 50, 
                    "shares_level": "normal"
                }, 
                {
                    "limit": -1, 
                    "name": "vsan", 
                    "reservation": 0, 
                    "shares": 50, 
                    "shares_level": "high"
                }
            ], 
            "state": "absent", 
            "switch": "nova_dvs", 
            "username": "administrator@vsphere.local", 
            "validate_certs": false, 
            "version": "version2"
        }
    }, 
    "resources_changed": [], 
    "result": "Disabled NIOC"
}

ansibot · 2018-08-14T22:37:51Z

cc @Akasurde @dav1x @warthog9
click here for bot help

ansibot · 2018-08-14T22:37:51Z

@vmwjoseph this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

ansibot · 2018-08-14T22:37:52Z

Hi @vmwjoseph,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

ansibot · 2018-08-14T22:45:19Z

The test ansible-test sanity --test pylint [explain] failed with 5 errors:

lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:137:38: undefined-variable Undefined variable 'changed'
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:137:58: undefined-variable Undefined variable 'result'
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:181:8: undefined-variable Undefined variable 'self'
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:183:8: undefined-variable Undefined variable 'self'
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:185:8: undefined-variable Undefined variable 'self'

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "test/sanity/code-smell/docs-build.py", line 100, in <module>
    main()
  File "test/sanity/code-smell/docs-build.py", line 17, in main
    raise subprocess.CalledProcessError(sphinx.returncode, cmd, output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['make', 'singlehtmldocs']' returned non-zero exit status 2.

The test ansible-test sanity --test no-dict-iteritems [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:153:23: use `dict.items` or `ansible.module_utils.six.iteritems` instead of `dict.iteritems`

The test ansible-test sanity --test pep8 [explain] failed with 25 errors:

lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:85:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:117:67: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:117:69: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:122:16: E225 missing whitespace around operator
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:123:15: E225 missing whitespace around operator
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:126:67: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:126:69: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:147:49: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:147:51: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:164:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:168:31: E126 continuation line over-indented for hanging indent
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:187:1: E305 expected 2 blank lines after class or function definition, found 1
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:52:161: E501 line too long (379 > 160 characters)
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:132:16: E225 missing whitespace around operator
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:133:15: E225 missing whitespace around operator
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:138:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:142:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:147:13: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:153:14: E231 missing whitespace after ','
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:154:33: E231 missing whitespace after ','
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:195:27: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:200:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:204:31: E126 continuation line over-indented for hanging indent
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:210:31: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:226:1: E305 expected 2 blank lines after class or function definition, found 1

The test ansible-test sanity --test validate-modules [explain] failed with 16 errors:

lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:0:0: E306 version_added is not a valid version number: 'future'
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:0:0: E312 No RETURN provided
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:0:0: E316 ANSIBLE_METADATA.metadata_version: not a valid value for dictionary value @ data['metadata_version']. Got '1.0'
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:0:0: E323 "datacenter_name" is listed in DOCUMENTATION.options, but not accepted by the module
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:0:0: E312 No RETURN provided
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:0:0: E316 ANSIBLE_METADATA.metadata_version: not a valid value for dictionary value @ data['metadata_version']. Got '1.0'
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:0:0: E324 Value for "default" from the argument_spec ('normal') for "shares_level" does not match the documentation (None)
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:0:0: E324 Value for "default" from the argument_spec (-1) for "limit" does not match the documentation (None)
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:0:0: E324 Value for "default" from the argument_spec (443) for "port" does not match the documentation (None)
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:0:0: E324 Value for "default" from the argument_spec (50) for "shares" does not match the documentation (None)
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:0:0: E324 Value for "default" from the argument_spec (True) for "validate_certs" does not match the documentation (False)
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:0:0: E325 argument_spec for "validate_certs" defines type="bool" but documentation does not
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:0:0: E326 Value for "choices" from the argument_spec (['normal', 'custom', 'low', 'high']) for "shares_level" does not match the documentation ([])
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:11:0: E106 Import found before documentation variables. All imports must appear below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:11:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:51:20: E302 DOCUMENTATION is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc_resource.py:51:20: error DOCUMENTATION: syntax error: could not find expected ':'

click here for bot help

ansibot · 2018-08-14T23:45:17Z

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "test/sanity/code-smell/docs-build.py", line 100, in <module>
    main()
  File "test/sanity/code-smell/docs-build.py", line 17, in main
    raise subprocess.CalledProcessError(sphinx.returncode, cmd, output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['make', 'singlehtmldocs']' returned non-zero exit status 2.

The test ansible-test sanity --test pep8 [explain] failed with 7 errors:

lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:123:16: E225 missing whitespace around operator
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:124:15: E225 missing whitespace around operator
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:133:16: E225 missing whitespace around operator
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:134:15: E225 missing whitespace around operator
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:149:49: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:149:51: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:189:1: E305 expected 2 blank lines after class or function definition, found 1

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:0:0: E306 version_added is not a valid version number: 'future'
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:0:0: E312 No RETURN provided
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:0:0: E323 "datacenter_name" is listed in DOCUMENTATION.options, but not accepted by the module

click here for bot help

ansibot · 2018-08-14T23:59:28Z

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:0:0: E312 No RETURN provided

click here for bot help

ansibot · 2018-08-15T00:34:05Z

@bedecarroll @chrrrles @dav1x @garbled1 @imjoseangel @jjahns @kamsz @lrivallain @nafpliot-ibm @nerzhul @oboukili @pdellaert @rhoop @ritzk @stravassac @tchernomax @warthog9 @woshihaoren

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

Akasurde

Could you please check if this works with vcsim and add testcase for this change ? You can check the existing testcases here.

lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py

Akasurde · 2018-08-16T06:23:08Z

@pdellaert @dericcrago Could you please review this ? Thanks,

lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py

Akasurde · 2018-11-19T11:33:32Z

@pdellaert Could you please check again so that we can proceed with this PR ? Thanks.

pdellaert

LGTM

ansibot · 2019-02-21T02:35:31Z

cc @lparkes
click here for bot help

ansibot · 2019-02-21T06:58:41Z

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:274:17: E117 over-indented
lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:276:17: E117 over-indented

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py:0:0: E319 RETURN.result.type: not a valid value for dictionary value @ data['result']['type']. Got 'string'

click here for bot help

ansibot · 2019-03-01T07:16:16Z

cc @Tomorrow9
click here for bot help

ansibot · 2019-05-04T08:40:22Z

cc @goneri
click here for bot help

ansibot · 2019-06-05T09:38:51Z

cc @pgbidkar
click here for bot help

Signed-off-by: Joseph Andreatta <joseph@vmware.com> Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

Akasurde · 2019-06-28T12:41:52Z

@vmwjoseph Thanks for the contribution.

Signed-off-by: Joseph Andreatta <joseph@vmware.com> Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

ansibot added ci_verified Changes made in this PR are causing tests to fail. and removed ci_verified Changes made in this PR are causing tests to fail. labels Aug 14, 2018

vmwjoseph changed the title ~~Add vmware_dvswitch_nioc and vmware_dvswitch_nioc_resource~~ Add vmware_dvswitch_nioc Aug 15, 2018

ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 15, 2018

Akasurde removed the needs_triage Needs a first human triage before being processed. label Aug 16, 2018

Akasurde self-requested a review August 16, 2018 06:11

Akasurde requested changes Aug 16, 2018

View reviewed changes

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 16, 2018

Akasurde reviewed Aug 16, 2018

View reviewed changes

lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py Outdated Show resolved Hide resolved

Akasurde reviewed Aug 16, 2018

View reviewed changes

lib/ansible/modules/cloud/vmware/vmware_dvswitch_nioc.py Outdated Show resolved Hide resolved

ansibot removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Nov 14, 2018

ckotte mentioned this pull request Nov 15, 2018

VMware: new module vmware_dvswitch_nioc_resource #48688

Closed

ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Nov 26, 2018

pdellaert approved these changes Nov 27, 2018

View reviewed changes

pdellaert approved these changes Jan 20, 2019

View reviewed changes

Akasurde approved these changes Feb 21, 2019

View reviewed changes

ansibot removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Feb 21, 2019

ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Feb 21, 2019

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 1, 2019

ansibot removed the new_contributor This PR is the first contribution by a new community member. label Mar 9, 2019

Akasurde mentioned this pull request Jun 28, 2019

VMware: Enabling Network IO Control when during creation of distributed virtual switch using vmware_dvswitch module in vsphere 6.7 #58494

Closed

Akasurde force-pushed the nioc branch from cb9887a to f898b23 Compare June 28, 2019 12:24

Akasurde self-assigned this Jun 28, 2019

VMware: Add new module vmware_dvswitch_nioc

f0ca8ea

Signed-off-by: Joseph Andreatta <joseph@vmware.com> Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

Akasurde force-pushed the nioc branch from f898b23 to f0ca8ea Compare June 28, 2019 12:34

ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 28, 2019

Akasurde merged commit 0a27ad6 into ansible:devel Jun 28, 2019

agowa pushed a commit to agowa/ansible-1 that referenced this pull request Jun 30, 2019

VMware: Add new module vmware_dvswitch_nioc (ansible#44147)

cc72fe1

Signed-off-by: Joseph Andreatta <joseph@vmware.com> Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

ansible locked and limited conversation to collaborators Aug 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VMware: new module vmware_dvswitch_nioc #44147

VMware: new module vmware_dvswitch_nioc #44147

vmwjoseph commented Aug 14, 2018 •

edited

ansibot commented Aug 14, 2018

ansibot commented Aug 14, 2018

ansibot commented Aug 14, 2018

ansibot commented Aug 14, 2018

ansibot commented Aug 14, 2018

ansibot commented Aug 14, 2018

ansibot commented Aug 15, 2018

Akasurde left a comment

Akasurde commented Aug 16, 2018

Akasurde commented Nov 19, 2018

pdellaert left a comment

ansibot commented Feb 21, 2019

ansibot commented Feb 21, 2019

ansibot commented Mar 1, 2019

ansibot commented May 4, 2019

ansibot commented Jun 5, 2019

Akasurde commented Jun 28, 2019

VMware: new module vmware_dvswitch_nioc #44147

VMware: new module vmware_dvswitch_nioc #44147

Conversation

vmwjoseph commented Aug 14, 2018 • edited

SUMMARY

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

ADDITIONAL INFORMATION

Enable NIOC

Change version2 to version3

Change resources

Rerun previous (should be no chnages)

Change version3 to version2

Disable NIOC

ansibot commented Aug 14, 2018

ansibot commented Aug 14, 2018

ansibot commented Aug 14, 2018

ansibot commented Aug 14, 2018

ansibot commented Aug 14, 2018

ansibot commented Aug 14, 2018

ansibot commented Aug 15, 2018

Akasurde left a comment

Choose a reason for hiding this comment

Akasurde commented Aug 16, 2018

Akasurde commented Nov 19, 2018

pdellaert left a comment

Choose a reason for hiding this comment

ansibot commented Feb 21, 2019

ansibot commented Feb 21, 2019

ansibot commented Mar 1, 2019

ansibot commented May 4, 2019

ansibot commented Jun 5, 2019

Akasurde commented Jun 28, 2019

vmwjoseph commented Aug 14, 2018 •

edited