Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AzureRMStorageAccount StorageV2 kind backport #44244

Merged
merged 2 commits into from
Sep 4, 2018
Merged

Add AzureRMStorageAccount StorageV2 kind backport #44244

merged 2 commits into from
Sep 4, 2018

Conversation

robsonpeixoto
Copy link
Contributor

@robsonpeixoto robsonpeixoto commented Aug 16, 2018 •
edited

(cherry picked from commit 2796be1)

close #38455

@robsonpeixoto robsonpeixoto mentioned this pull request Aug 16, 2018
Merged
@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2018

cc @haroldwongms @nitzmahone @trstringer @xscript @yuwzho @zikalino
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2018

Hi @robsonpeixoto,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 azure backport This PR does not target the devel branch. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:certified This issue/PR relates to certified code. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 16, 2018
@yuwzho
Copy link
Contributor

yuwzho commented Aug 16, 2018

@mattclay

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Aug 16, 2018
@ansibleazurebot ansibleazurebot mentioned this pull request Aug 17, 2018
Closed
@Fred-sun
Copy link
Contributor

@mattclay Could you help take a look this PR? Thanks!

@Fred-sun
Copy link
Contributor

@robsonpeixoto Thanks for the contribution, Could you help confirm this PR ready for review or not? Thanks!

@Fred-sun
Copy link
Contributor

@mattclay Could you help take a look this PR? Thanks!

@robsonpeixoto
Copy link
Contributor Author

The PR is ready for review, @Fred-sun

@Fred-sun
Copy link
Contributor

@robsonpeixoto Thanks for the contribute, I will test and push to review. Thanks!

@Fred-sun
Copy link
Contributor

@yuwzho @mattclay Could you help to review this PR? Thanks!

@robsonpeixoto
Copy link
Contributor Author

@Fred-sun it's only a backport of this commit 2796be1

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 28, 2018
@mattclay mattclay merged commit 207974f into ansible:stable-2.6 Sep 4, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 azure backport This PR does not target the devel branch. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:certified This issue/PR relates to certified code. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@robsonpeixoto @ansibot @yuwzho @Fred-sun @mattclay