Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ios_vlan and ios_l2_interface issues in 2.6 #44250

Merged
merged 4 commits into from
Aug 21, 2018
Merged

Fix ios_vlan and ios_l2_interface issues in 2.6 #44250

merged 4 commits into from
Aug 21, 2018

Conversation

NilashishC
Copy link
Contributor

@NilashishC
Fixes ios_l2_interface and ios_vlan not working on certain interface …
9cc33bb 
…types issue (#43819)

* Fixes #43654 and #43582

* Remove q statement

* Fix shippable errors

* Fix more shippable errors

* Fix unittest

(cherry picked from commit b14f256)
@NilashishC
Added Change Logs
efe2fb7
@NilashishC
Fixed changelog entry
03caeb8
@NilashishC
Fixed changelog entry - 2
075074d
@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2018

cc @Qalthos @ganeshrn @gdpak @Qalthos @rcarrillocruz @trishnaguha
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2018

Hi @NilashishC,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Aug 16, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Aug 16, 2018
@mattclay mattclay merged commit 1bcc192 into ansible:stable-2.6 Aug 21, 2018
@dagwieers dagwieers added ios Cisco IOS community cisco Cisco technologies labels Feb 27, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@achinthagunasekara achinthagunasekara achinthagunasekara approved these changes

Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community module This issue/PR relates to a module. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@NilashishC @ansibot @achinthagunasekara @dagwieers @mattclay @samdoran