Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use single parameter for source-interface #44260

Merged
merged 4 commits into from
Aug 16, 2018
Merged

Use single parameter for source-interface #44260

merged 4 commits into from
Aug 16, 2018

Conversation

NilashishC
Copy link
Contributor

@NilashishC NilashishC commented Aug 16, 2018 •
edited

SUMMARY
  • Eliminates the need to have two separate parameters for configuring source-interface
  • Uses normalize_interface() to convert interfaces into correct form if entire interface name is not supplied
  • Supports interfaces with formats like - 'Ethernet1/3/3'
  • Modified tests
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

nxos_logging.py

ANSIBLE VERSION
devel

@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2018

cc @mikewiebe @rahushen @rcarrillocruz @trishnaguha @tstoner
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2018

Hi @NilashishC,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Aug 16, 2018
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Aug 16, 2018
@NilashishC NilashishC merged commit d63ba59 into ansible:devel Aug 16, 2018
@NilashishC NilashishC deleted the modify_src_int branch August 16, 2018 17:03
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NilashishC @ansibot @Qalthos @dagwieers