Correct the default doc for attached in ec2_eni

[mdaniel]

Also corrected a typo in the summary

SUMMARY

The default: documentation for ec2_eni erroneously claimed that the default was yes but it is in fact None

ISSUE TYPE

• Docs Pull Request

COMPONENT NAME

ec2_eni

ANSIBLE VERSION

devel

ADDITIONAL INFORMATION

Someone discovered that if they omitted attached: yes it causes the ec2_eni module to do nothing after creating the ENI, and that question is likely because the docs claim the default is yes.

[ansibot]

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

test/sanity/validate-modules/ignore.txt:57:1: A102 Remove since "lib/ansible/modules/cloud/amazon/ec2_eni.py" passes "E324" test

click here for bot help

[ansibot]

cc @wimnat
click here for bot help

[ansibot]

Hi @mdaniel,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

[mdaniel]

test/sanity/validate-modules/ignore.txt:57:1: A102 Remove since "lib/ansible/modules/cloud/amazon/ec2_eni.py" passes "E324" test

Maybe I'm doing something wrong, but running that same ansible-test sanity --test validate-modules on my branch yields almost 400 errors:

ERROR: Found 395 validate-modules issue(s) which need to be resolved:

Don't get me wrong: I am glad to apply the fix ansibot suggested, but is that the expected output from ansible-test?

Or, worse, why was E324 suppressed in the first place? It feels like if the one item that I fixed broke a suppression, but that item negatively affected an actual user, then the value of the suppression is suspicious.

---

update: I fixed the E325 errors that were being suppressed, but my question stands about why such a system is in place for such infinitesimal fixes?

[ansibot]

cc @mattclay
click here for bot help