Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated ec2_facts #44536

Merged
merged 2 commits into from
Aug 22, 2018
Merged

Remove deprecated ec2_facts #44536

merged 2 commits into from
Aug 22, 2018

Conversation

sivel
Copy link
Member

@sivel sivel commented Aug 22, 2018

SUMMARY

Remove deprecated ec2_facts

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/amazon/_ec2_facts.py

ANSIBLE VERSION
2.7
ADDITIONAL INFORMATION

@sivel sivel requested review from ryansb and s-hertel August 22, 2018 21:07
@ansibot
Copy link
Contributor

ansibot commented Aug 22, 2018

cc @roadmapper @silviud
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 22, 2018

Hi @sivel,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 aws bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. deprecated This issue/PR relates to a deprecated module. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 22, 2018
@roadmapper
Copy link
Contributor

Does the CHANGELOG need to be updated for this deprecated module removal?

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Aug 22, 2018
@sivel
Copy link
Member Author

sivel commented Aug 22, 2018

Does the CHANGELOG need to be updated for this deprecated module removal?

You caught me before I got it added. I created the PR first, to get a URL to link back to in the changelog

@sivel sivel merged commit a1febd9 into ansible:devel Aug 22, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb approved these changes

@s-hertel s-hertel Awaiting requested review from s-hertel

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 aws bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. deprecated This issue/PR relates to a deprecated module. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sivel @ansibot @roadmapper @ryansb