Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure_rm_virtualmachine: Add 'accept_terms' #44701

Merged
merged 1 commit into from
Aug 30, 2018
Merged

azure_rm_virtualmachine: Add 'accept_terms' #44701

merged 1 commit into from
Aug 30, 2018

Conversation

spmp
Copy link
Contributor

@spmp spmp commented Aug 27, 2018

azure_rm_virtualmachine: Add 'accept_terms' for accepting terms when deploying paid marketplace images

SUMMARY

Paid Azure Marketplace images requiring accepting the terms of the image and plan before being deployed. Usually this takes place in the Azure web frontend or via az cli prior to provisioning.

As azure_rm_virtualmachine is for programatically deploying VM images it should have the capacity to accept these terms at the time of deployment. The accept_terms (True) does just this.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

azure_rm_virtualmachine

ANSIBLE VERSION
2.7.0
ADDITIONAL INFORMATION

Tests are included, but commented out as special CI permissions are required.

@ansibot
Copy link
Contributor

ansibot commented Aug 27, 2018

cc @haroldwongms @mattclay @nitzmahone @trstringer @xscript @yuwzho @zikalino
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 27, 2018

Hi @spmp,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 azure cloud core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:certified This issue/PR relates to certified code. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Aug 27, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 27, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_storageaccount.py:0:0: E326 Value for "choices" from the argument_spec ([]) for "account_type" does not match the documentation (['Premium_LRS', 'Standard_GRS', 'Standard_LRS', 'Standard_RAGRS', 'Standard_ZRS'])

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 27, 2018
@ansibleazurebot ansibleazurebot mentioned this pull request Aug 27, 2018
Closed
@zikalino zikalino closed this Aug 27, 2018
@zikalino zikalino reopened this Aug 27, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 27, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_storageaccount.py:0:0: E326 Value for "choices" from the argument_spec ([]) for "account_type" does not match the documentation (['Premium_LRS', 'Standard_GRS', 'Standard_LRS', 'Standard_RAGRS', 'Standard_ZRS'])

click here for bot help

@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Aug 27, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 27, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_storageaccount.py:0:0: E326 Value for "choices" from the argument_spec ([]) for "account_type" does not match the documentation (['Premium_LRS', 'Standard_GRS', 'Standard_LRS', 'Standard_RAGRS', 'Standard_ZRS'])

click here for bot help

@spmp
Copy link
Contributor Author

spmp commented Aug 27, 2018 •
edited

Lights are green @jborean93, @zikalino, @mattclay, @nitzmahone

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 27, 2018
@Fred-sun
Copy link
Contributor

@spmp Thanks for the contribution, Could you help confirm the PR ready for review or not? If yes, I will push to review. Thanks!

@spmp
Copy link
Contributor Author

spmp commented Aug 28, 2018 via email •
edited

@Fred-sun
Copy link
Contributor

@jborean93, @zikalino, @mattclay, @nitzmahone Could you help review this PR? Thanks!

@spmp
azure_rm_virtualmachine: Add 'accept_terms' for accepting terms when …
6418698 
…deploying paid marketplace images

azure_rm_storageaccount: Add 'StandardSSD_LRS', and choices to correct unrelated sanity error
@nitzmahone nitzmahone merged commit 2541a8c into ansible:devel Aug 30, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 azure cloud core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:certified This issue/PR relates to certified code. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@spmp @ansibot @Fred-sun @nitzmahone @bcoca @zikalino