Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add azure_rm_cdnprofile and azure_rm_cdnprofile_facts #45097

Merged
merged 12 commits into from
Sep 27, 2018

Conversation

yungezz
Copy link
Contributor

@yungezz yungezz commented Sep 3, 2018

SUMMARY

add new modules: azure_rm_cdnprofile and azure_rm_cdnprofile_facts.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
ANSIBLE VERSION
ansible 2.7
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Sep 3, 2018

@ansibot
Copy link
Contributor

ansibot commented Sep 3, 2018

@yungezz this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 3, 2018

Hi @yungezz,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 azure cloud module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Sep 3, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 3, 2018

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/cloud/azure/azure_rm_cdnprofile.py:291:0: missing-final-newline Final newline missing
lib/ansible/modules/cloud/azure/azure_rm_cdnprofile_facts.py:253:0: missing-final-newline Final newline missing

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/module_utils/azure_rm_common.py:952:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_cdnprofile.py:291:11: W292 no newline at end of file
lib/ansible/modules/cloud/azure/azure_rm_cdnprofile_facts.py:253:11: W292 no newline at end of file

click here for bot help

@yungezz
Copy link
Contributor Author

yungezz commented Sep 4, 2018

hi @mattclay , as you know, CDN creation test failed in this integration test https://app.shippable.com/github/ansible/ansible/runs/82246/77/console, I've checked with service team, the CI subscription need to register CDN provider by following this guideline https://docs.microsoft.com/en-us/azure/azure-resource-manager/resource-manager-supported-services#portal, pls note provider to registered is Microsoft.Cdn.

@yungezz
Copy link
Contributor Author

yungezz commented Sep 5, 2018

Hi @mattclay , could you pls help to do the registration as above? thanks.

@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Sep 5, 2018
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Sep 6, 2018
@yungezz
Copy link
Contributor Author

yungezz commented Sep 7, 2018

hi @mattclay , could you help on the configuration change as mentioned above? thanks.

@mattclay
Copy link
Member

mattclay commented Sep 7, 2018

@yungezz I've registered the Microsoft.Cdn provider.

@yungezz
Copy link
Contributor Author

yungezz commented Sep 7, 2018

Thank you @mattclay ! will rebase the PR.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 15, 2018
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Sep 21, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 21, 2018

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_cdnprofile.py:147:0: AttributeError: 'AzureRMCdnprofile' object has no attribute 'module_arGg_spec'

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_cdnprofile.py:147:0: AttributeError: 'AzureRMCdnprofile' object has no attribute 'module_arGg_spec'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_cdnprofile.py:147:0: AttributeError: 'AzureRMCdnprofile' object has no attribute 'module_arGg_spec'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_cdnprofile.py:147:0: AttributeError: 'AzureRMCdnprofile' object has no attribute 'module_arGg_spec'

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/azure/azure_rm_cdnprofile.py:106:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_cdnprofile.py:295:1: E302 expected 2 blank lines, found 1

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_cdnprofile.py:0:0: E321 Exception attempting to import module for argument_spec introspection, ''AzureRMCdnprofile' object has no attribute 'module_arGg_spec''

click here for bot help

@yungezz yungezz closed this Sep 22, 2018
@yungezz yungezz reopened this Sep 22, 2018
@yungezz
Copy link
Contributor Author

yungezz commented Sep 25, 2018

ready_for_review

@jborean93 jborean93 merged commit 69594c5 into ansible:devel Sep 27, 2018
@yungezz yungezz deleted the yungez-cdnprofile1 branch April 9, 2019 02:11
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.7 This issue/PR affects Ansible v2.7 azure cloud module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants