Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add single quotes around package name #45152

Merged
merged 1 commit into from
Sep 6, 2018
Merged

Add single quotes around package name #45152

merged 1 commit into from
Sep 6, 2018

Conversation

suonto
Copy link
Contributor

@suonto suonto commented Sep 4, 2018 •
edited

pip install ansible[azure] results in zsh: no matches found: ansible[azure] at least in my computer (zsh on Ubuntu). I don't know if it is the case with all shells, but at least for me it is. Since square brackets [] are special characters in bash, I propose adding single quotes to make sure that package name is always interpreted as literal. The same error is also resolvable by setting noglob.

SUMMARY
ISSUE TYPE
  • Docs Pull Request
ANSIBLE VERSION
2.6.3

Add single quotes around package name
2145bfd 
<!--- Your description here -->
`pip install ansible[azure]` results in `zsh: no matches found: ansible[azure]` at least in my computer (zsh on Ubuntu). I don't know if it is the case with all shells, but at least for me it is. Since square brackets `[]` are special characters in bash, I propose adding single quotes to make sure that package name is always interpreted as literal. The same error is also resolvable by setting noglob.
@ansibot
Copy link
Contributor

ansibot commented Sep 4, 2018

cc @acozine
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 docs This issue/PR relates to or includes documentation. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 4, 2018
@acozine
Copy link
Contributor

acozine commented Sep 4, 2018

Hi @suonto. Thanks for opening a PR to improve the documentation. Before we merge a change, we'd like to make sure it will both fix your problem and not create new problems for other users. Can you include the output of your suggested change in zsh in a comment? Also, can you test it in bash and a few other shells, and post the output from those in the PR as well?

@acozine acozine added waiting_on_contributor This would be accepted but there are no plans to actively work on it. and removed needs_triage Needs a first human triage before being processed. labels Sep 4, 2018
@suonto
Copy link
Contributor Author

suonto commented Sep 6, 2018

@acozine I have just made a more comprehensive test with sh (plain bourne shell), bash and zsh. The results are the following:

  • sh: install command works both with and without single quotes
  • bash: install command works both with and without single quotes
  • zsh: install command works only with single quotes or by setting noglob. Otherwise I get zsh: no matches found: ansible[azure]

All successfull pip install commands result in identical output, so I'm not pasting it here unless you specifically ask for it again.

@acozine acozine removed the waiting_on_contributor This would be accepted but there are no plans to actively work on it. label Sep 6, 2018
@acozine
Copy link
Contributor

acozine commented Sep 6, 2018

@suonto thanks for seeing this PR through - we appreciate your attention to detail and your interest in making the documentation better.

@acozine acozine merged commit 0d81386 into ansible:devel Sep 6, 2018
@acozine acozine added this to To do in OLD Ansible Documentation via automation Sep 17, 2018
@acozine acozine moved this from To do to Backport to 2.7 in OLD Ansible Documentation Sep 17, 2018
@samccann samccann mentioned this pull request Sep 19, 2018
Merged
acozine pushed a commit to samccann/ansible that referenced this pull request Sep 19, 2018
@acozine
Add single quotes around package name (ansible#45152)
2502b9d 
<!--- Your description here -->
`pip install ansible[azure]` results in `zsh: no matches found: ansible[azure]` at least in my computer (zsh on Ubuntu). I don't know if it is the case with all shells, but at least for me it is. Since square brackets `[]` are special characters in bash, I propose adding single quotes to make sure that package name is always interpreted as literal. The same error is also resolvable by setting noglob.
(cherry picked from commit 0d81386)
acozine pushed a commit that referenced this pull request Sep 20, 2018
@samccann @acozine
[WIP] Backport/2.7/batch port (#45859)
ceb474b 
Batch of docs backports:

* docs: Clarify include_task v import_tasks with conditionals (#43856)
(cherry picked from commit 6be42a2)

* Add single quotes around package name (#45152)
(cherry picked from commit 0d81386)

* prefer ansible_facts namespace and dict notation (#44980)
(cherry picked from commit 4451044)

* fix cherrypick conflict - scenario_guides

* Update implicit_localhost.rst (#45455)
(cherry picked from commit f68cd1a)

* updated fbsd install instructions (#45309)
(cherry picked from commit e9c2695)

* Change "Defaulting Undefined Variables" (#41379)
(cherry picked from commit e35c4be)

* adds license details to dev guide pages (#45574)
(cherry picked from commit 6e68d77)

* FAQ: fix a typo, add link to 'vars' lookup (#42412)
(cherry picked from commit 95649dc)

* Fix link and toctree (#45595)
(cherry picked from commit 6999bf3)

* Improve the local toctree (and title) (#45590)
(cherry picked from commit afea00f)

* Add undocumented configuration parameter and explain in porting guide (#36059)
(cherry picked from commit a892a6e)

* Simplify PPA installation for Ubuntu (#45690)
(cherry picked from commit 78e9f45)

* adding git+ssh uri scheme (#36025)
(cherry picked from commit 84a4257)

* Add workaround for non-standard kerberos environments (#41465)
(cherry picked from commit 4e532e0)

* Restore license agreement (#45809)
(cherry picked from commit f430f60)

* partial cherry-pick - lenovo doc update PR 45483
@acozine acozine moved this from Backport to 2.7 to Done in OLD Ansible Documentation Sep 20, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 docs This issue/PR relates to or includes documentation. feature This issue/PR relates to a feature request. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
OLD Ansible Documentation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@suonto @ansibot @acozine