docs: Clarify include_task v import_tasks with conditionals #43856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
jborean93
removed
the
needs_triage
bcoca
approved these changes
Aug 9, 2018
ansibot
added
the
stale_ci
acozine
suggested changes
Aug 30, 2018
| Thus if ``x`` is initially undefined, the ``debug`` task will be skipped. By using ``include_tasks`` instead of ``import_tasks``, | ||
| both tasks from ``other_tasks.yml`` will be executed as expected. | ||
|
|
||
| For more information on the differences between ``include`` v ``importing`` see :ref:`playbooks_reuse`. |
There was a problem hiding this comment.
typo? I'd make this "the differences between include and import . . . "
ansibot
added
the
needs_revision
acozine
added
the
waiting_on_contributor
The example given here is currently wrong, as the "set_fact" task will be executed when using "import_tasks". Correct and clarify this situation by expanding out what is happening in the easy-to-get-wrong import mode. Add some additional links to "group_by" documentation and the main import/include discussion. Closes: ansible#31596
ansibot
removed
the
stale_ci
acozine
approved these changes
Sep 5, 2018
|
Thanks @ianw! |
acozine
pushed a commit
to samccann/ansible
that referenced
this pull request
Sep 19, 2018
…43856) Correct and clarify "set_fact" example, expanding on what is happening in the easy-to-get-wrong import mode. Add some additional links to "group_by" documentation and the main import/include discussion. Closes: ansible#31596 (cherry picked from commit 6be42a2)
acozine
pushed a commit
that referenced
this pull request
Sep 20, 2018
Batch of docs backports: * docs: Clarify include_task v import_tasks with conditionals (#43856) (cherry picked from commit 6be42a2) * Add single quotes around package name (#45152) (cherry picked from commit 0d81386) * prefer ansible_facts namespace and dict notation (#44980) (cherry picked from commit 4451044) * fix cherrypick conflict - scenario_guides * Update implicit_localhost.rst (#45455) (cherry picked from commit f68cd1a) * updated fbsd install instructions (#45309) (cherry picked from commit e9c2695) * Change "Defaulting Undefined Variables" (#41379) (cherry picked from commit e35c4be) * adds license details to dev guide pages (#45574) (cherry picked from commit 6e68d77) * FAQ: fix a typo, add link to 'vars' lookup (#42412) (cherry picked from commit 95649dc) * Fix link and toctree (#45595) (cherry picked from commit 6999bf3) * Improve the local toctree (and title) (#45590) (cherry picked from commit afea00f) * Add undocumented configuration parameter and explain in porting guide (#36059) (cherry picked from commit a892a6e) * Simplify PPA installation for Ubuntu (#45690) (cherry picked from commit 78e9f45) * adding git+ssh uri scheme (#36025) (cherry picked from commit 84a4257) * Add workaround for non-standard kerberos environments (#41465) (cherry picked from commit 4e532e0) * Restore license agreement (#45809) (cherry picked from commit f430f60) * partial cherry-pick - lenovo doc update PR 45483
sivel
removed
the
waiting_on_contributor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The example given here is currently wrong, as the
set_facttask willbe executed when using
import_tasks.Correct and clarify this situation by expanding out what is happening
in the easy-to-get-wrong import mode.
Add some additional links to
group_bydocumentation and the mainimport/include discussion.
Fixes: #31596
ISSUE TYPE