Make vmware_guest honor "wait_for_ip_address" when powering on a VM

[albers]

SUMMARY

Fixes #45223

It turned out that the vmware_guest module does not check for ip availability at all in the desired_operation='set_vm_power_state' case.

This PR adds a call to wait_for_vm_ip in the same manner as done in vmware_dploy_ovf.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

vmware_guest

ANSIBLE VERSION

ansible 2.7.0b1.post0 (stable-2.7 8a8da98546) last updated 2018/09/03 10:13:33 (GMT +200)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/user/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/user/devops/ansible/ansible/lib/ansible
  executable location = /home/user/devops/ansible/ansible/bin/ansible
  python version = 2.7.12 (default, Dec  4 2017, 14:50:18) [GCC 5.4.0 20160609]

ADDITIONAL INFORMATION

The return value's instance value is updated with the last poll result so that the IP is also available in the module's return value.

This module now uses the same shared function wait_for_vm_ip as vmware_deploy_ovf does, so it is inherently affected by #45159. As the undetected timeout occurs after 5 minutes, this should not be a big issue in this context.

[ansibot]

cc @Akasurde @dav1x @nerzhul @pdellaert @warthog9
click here for bot help

[ansibot]

Hi @albers,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

[Im0]

Thanks @albers - I have tested on 6.7 and works fine for me.

[Akasurde]

@albers Thanks for the contribution. @Im0 Thanks for reviewing and testing.

[albers]

@Akasurde Can we get this one into the 2.7 release, please?

[Akasurde]

@albers I already did - #45540 (comment)

[albers]

Thanks!

[albers]

@Akasurde Sorry, but this is another PR. #45429 was pulled in but this one (#45226) not.

[albers]

@Akasurde Can we please, please get this one into 2.7?

[pdellaert]

Ok, just removing the comment, i must be tired :). Missed that it didn't yet make it. @Akasurde will have to cherry-pick, if that is still allowed for 2.7

[Akasurde]

@albers @pdellaert PR for Stable-2.7 #46248