Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws] Fix check mode bug using ec2_key when a key already exists and key_ma… #45320

Merged
merged 1 commit into from
Oct 22, 2018
Merged

[aws] Fix check mode bug using ec2_key when a key already exists and key_ma… #45320

merged 1 commit into from
Oct 22, 2018

Conversation

s-hertel
Copy link
Contributor

@s-hertel s-hertel commented Sep 6, 2018

…terial has been provided

SUMMARY

Fixes #40318

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_key

ANSIBLE VERSION
ansible 2.8.0.dev0

@ansibot
Copy link
Contributor

ansibot commented Sep 6, 2018

cc @prasadkatti @zbal
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 6, 2018

Hi @s-hertel,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 aws bug This issue/PR relates to a bug. cloud committer_review In order to be merged, this PR must follow the certified review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:certified This issue/PR relates to certified code. labels Sep 6, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 6, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_key.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_key.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_key.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_key.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_key.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "test/sanity/code-smell/docs-build.py", line 100, in <module>
    main()
  File "test/sanity/code-smell/docs-build.py", line 17, in main
    raise subprocess.CalledProcessError(sphinx.returncode, cmd, output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['make', 'singlehtmldocs']' returned non-zero exit status 2.

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_key.py:199:0: syntax-error positional argument follows keyword argument (&lt;string&gt;, line 199)

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_key.py:199:0: SyntaxError: non-keyword arg after keyword arg

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_key.py:199:0: SyntaxError: non-keyword arg after keyword arg

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_key.py:199:47: SyntaxError: positional argument follows keyword argument

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_key.py:199:47: SyntaxError: positional argument follows keyword argument

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_key.py:199:47: SyntaxError: positional argument follows keyword argument

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/cloud/amazon/ec2_key.py:0:0: E401 Python SyntaxError while parsing module
test/sanity/validate-modules/ignore.txt:61:1: A102 Remove since "lib/ansible/modules/cloud/amazon/ec2_key.py" passes "E325" test

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_key.py:199:47: python-syntax-error positional argument follows keyword argument (<unknown>, line 199)

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed committer_review In order to be merged, this PR must follow the certified review workflow. labels Sep 6, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Sep 6, 2018
@s-hertel s-hertel requested a review from ryansb September 7, 2018 13:12
@ansibot ansibot added committer_review In order to be merged, this PR must follow the certified review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 7, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 18, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community. and removed committer_review In order to be merged, this PR must follow the certified review workflow. support:certified This issue/PR relates to certified code. labels Oct 12, 2018
@mooninite
Copy link
Contributor

I can report that this patch fixes the issue for me in Ansible 2.7.0.

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 18, 2018
@ryansb ryansb merged commit c58c0b8 into ansible:devel Oct 22, 2018
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@s-hertel @Tomorrow9
[aws] Fix check mode bug in ec2_key (ansible#45320)
1a7a721 
Fix incorrect ec2_key check-mode behavior when a key already exists and key_material has been provided
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 aws bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ec2_key duplicates key in dry run
5 participants
@s-hertel @ansibot @mooninite @ryansb @samdoran