Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws] Remove deprecated ec2_vpc_dhcp_options alias #45321

Merged
merged 1 commit into from
Sep 7, 2018
Merged

[aws] Remove deprecated ec2_vpc_dhcp_options alias #45321

merged 1 commit into from
Sep 7, 2018

Conversation

ryansb
Copy link
Contributor

@ryansb ryansb commented Sep 6, 2018

SUMMARY

Remove deprecated ec2_vpc_dhcp_options alias. In 2.8 it is removed leaving only ec2_vpc_dhcp_option.

Fixes #44989

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ANSIBLE VERSION
ADDITIONAL INFORMATION

@ryansb ryansb requested a review from s-hertel September 6, 2018 20:36
@ansibot
Copy link
Contributor

ansibot commented Sep 6, 2018

cc @joelthompson
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 6, 2018

Hi @ryansb,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 aws bug This issue/PR relates to a bug. cloud committer_review In order to be merged, this PR must follow the certified review workflow. deprecated This issue/PR relates to a deprecated module. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:certified This issue/PR relates to certified code. labels Sep 6, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Sep 6, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. committer_review In order to be merged, this PR must follow the certified review workflow. and removed committer_review In order to be merged, this PR must follow the certified review workflow. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 7, 2018
@s-hertel s-hertel merged commit 8d363f7 into ansible:devel Sep 7, 2018
@chaseduffin chaseduffin mentioned this pull request Jul 10, 2019
Merged
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 aws bug This issue/PR relates to a bug. cloud committer_review In order to be merged, this PR must follow the certified review workflow. deprecated This issue/PR relates to a deprecated module. module This issue/PR relates to a module. support:certified This issue/PR relates to certified code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ec2_vpc_dhcp_option contains deprecated call to be removed in 2.8
4 participants
@ryansb @ansibot @s-hertel @samdoran