Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure_rm_virtualmachine.py #45325

Merged
merged 6 commits into from
Sep 20, 2018

Conversation

isopy
Copy link
Contributor

@isopy isopy commented Sep 6, 2018

SUMMARY

A lot of Azure images are not cloud-init ready and need to be prepared manually before attempting to use the custom_data option of this module. Adding a line to the description to make others aware. If, like me, they are used to working with AWS AMIs that all seem to have cloud-init baked in, this could prevent some troubleshooting as to why their custom_data scripts aren't running in Azure.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME
lib/ansible/modules/cloud/azure/azure_rm_virtualmachine.py
ANSIBLE VERSION
ansible 2.6.3
ADDITIONAL INFORMATION

N/A

A lot of Azure images are not cloud-init ready and need to be prepared manually before attempting to use the custom_data option of this module. Adding a line to the description to make others aware. If, like me, they are used to working with AWS AMIs that all seem to have cloud-init baked in, this could prevent some troubleshooting as to why their custom_data scripts aren't running in Azure.
@ansibot
Copy link
Contributor

ansibot commented Sep 6, 2018

@ansibot
Copy link
Contributor

ansibot commented Sep 6, 2018

Hi @isopy,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 azure cloud committer_review In order to be merged, this PR must follow the certified review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. small_patch support:certified This issue/PR relates to certified code. labels Sep 6, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 6, 2018

The test ansible-test sanity --test docs-build [explain] failed with 2 errors:

docs/docsite/rst/modules/azure_rm_virtualmachine_module.rst:22:0: warning: Unknown target name: "these steps < https://docs.microsoft.com/en-us/azure/virtual-machines/linux/cloudinit-prepare-custom-image>".
docs/docsite/rst/modules/azure_rm_virtualmachine_module.rst:22:0: warning: Unknown target name: "this list < https://docs.microsoft.com/en-us/azure/virtual-machines/linux/using-cloud-init#cloud-init-overview>".

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed committer_review In order to be merged, this PR must follow the certified review workflow. labels Sep 6, 2018
@yuwzho
Copy link
Contributor

yuwzho commented Sep 7, 2018

HI @isopy Thanks for your contribution, your documentation seems contain some syntax error, would you mind fixing this? Please refer this site: https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_documenting.html#formatting-functions to refine your doc

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Sep 7, 2018
@isopy
Copy link
Contributor Author

isopy commented Sep 7, 2018

@yuwzho my apologies. first time using this type of syntax and misread the usage of of L(). This latest commit should fix it.

@ansibot ansibot added committer_review In order to be merged, this PR must follow the certified review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 7, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed committer_review In order to be merged, this PR must follow the certified review workflow. support:certified This issue/PR relates to certified code. labels Sep 15, 2018
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 15, 2018
@acozine acozine added this to To do in OLD Ansible Documentation via automation Sep 17, 2018
@Fred-sun
Copy link
Contributor

@isopy Thanks for the contribution, Could you help confirm that you have finished change this PR or not? if finish, I will push to review. Thanks!

@isopy
Copy link
Contributor Author

isopy commented Sep 20, 2018

@Fred-sun Confirming that I’m finished changing this PR.

@yuwzho
Copy link
Contributor

yuwzho commented Sep 20, 2018

shipit

@zikalino zikalino merged commit 1a3bc7d into ansible:devel Sep 20, 2018
@isopy isopy deleted the update_description_azure_rm_vm branch September 20, 2018 20:32
@acozine acozine moved this from To do to Done in OLD Ansible Documentation Nov 8, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 azure cloud core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants