-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update azure_rm_virtualmachine.py #45325
Conversation
A lot of Azure images are not cloud-init ready and need to be prepared manually before attempting to use the custom_data option of this module. Adding a line to the description to make others aware. If, like me, they are used to working with AWS AMIs that all seem to have cloud-init baked in, this could prevent some troubleshooting as to why their custom_data scripts aren't running in Azure.
Hi @isopy, Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for azure. |
The test
|
HI @isopy Thanks for your contribution, your documentation seems contain some syntax error, would you mind fixing this? Please refer this site: https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_documenting.html#formatting-functions to refine your doc |
@yuwzho my apologies. first time using this type of syntax and misread the usage of of L(). This latest commit should fix it. |
@isopy Thanks for the contribution, Could you help confirm that you have finished change this PR or not? if finish, I will push to review. Thanks! |
@Fred-sun Confirming that I’m finished changing this PR. |
shipit |
SUMMARY
A lot of Azure images are not cloud-init ready and need to be prepared manually before attempting to use the custom_data option of this module. Adding a line to the description to make others aware. If, like me, they are used to working with AWS AMIs that all seem to have cloud-init baked in, this could prevent some troubleshooting as to why their custom_data scripts aren't running in Azure.
ISSUE TYPE
COMPONENT NAME
ANSIBLE VERSION
ADDITIONAL INFORMATION
N/A