Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check execute_lock boolean, not lock string var #45329

Merged
merged 1 commit into from
Oct 10, 2018
Merged

fix: check execute_lock boolean, not lock string var #45329

merged 1 commit into from
Oct 10, 2018

Conversation

rdkls
Copy link
Contributor

@rdkls rdkls commented Sep 7, 2018

SUMMARY

Check boolean var set earlier, instead of string as passed in
Might help in future to use more explicit var names e.g. lock_type, should_execute_lock etc

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

modules/network/netconf/netconf_config.py

ANSIBLE VERSION
2.8.0.dev0

@ansibot
Copy link
Contributor

ansibot commented Sep 7, 2018

cc @Qalthos @ganeshrn @gdpak @justjais @lpenz @rcarrillocruz @trishnaguha @userlerueda
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 7, 2018

Hi @rdkls,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. small_patch support:network This issue/PR relates to code supported by the Ansible Network Team. labels Sep 7, 2018
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Sep 7, 2018
@gdpak gdpak requested a review from ganeshrn September 12, 2018 13:54
@mscherer
Copy link
Contributor

shipit

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 16, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 24, 2018

cc @NilashishC
click here for bot help

@rdkls
Copy link
Contributor Author

rdkls commented Oct 10, 2018

Hi @NilashishC possible to get this approved?

@privateip privateip merged commit 5e67981 into ansible:devel Oct 10, 2018
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@rdkls @Tomorrow9
fix: check execute_lock boolean, not lock string var (ansible#45329)
0dc1b7b
apt-itude pushed a commit to 128technology/ansible that referenced this pull request Feb 19, 2019
@rdkls @apt-itude
fix: check execute_lock boolean, not lock string var (ansible#45329)
22c8ee2
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn Awaiting requested review from ganeshrn

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category new_contributor This PR is the first contribution by a new community member. small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rdkls @ansibot @mscherer @privateip @mkrizek