Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more docs build errors #45364

Merged
merged 12 commits into from
Sep 11, 2018
Merged

Remove more docs build errors #45364

merged 12 commits into from
Sep 11, 2018

Conversation

acozine
Copy link
Contributor

@acozine acozine commented Sep 7, 2018

SUMMARY

This PR:

  • Gets rid of the last of the "not-in-toctree" warnings from our sphinx docs build by either adding pages to a TOC somewhere or marking them :orphan:.
  • Removes the "not-in-toctree" error from the ignore list.
  • Normalizes some headings (with notation from Make docsite documentation headers consistent #35520 and Sentence case for heading text).
  • Removes a bunch of whitespace.
ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs.ansible.com

ANSIBLE VERSION

2.8

@acozine acozine added the docs This issue/PR relates to or includes documentation. label Sep 7, 2018
@acozine acozine changed the title Whack an error Remove more docs build errors Sep 7, 2018
@acozine acozine mentioned this pull request Sep 7, 2018
Closed
@acozine acozine added this to To do in OLD Ansible Documentation via automation Sep 7, 2018
@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 7, 2018
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Sep 7, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 7, 2018

cc @mattclay
click here for bot help

@ansibot ansibot added the test This PR relates to tests. label Sep 7, 2018
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Sep 7, 2018
samccann
samccann approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, here and on the test site.

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 10, 2018
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Sep 11, 2018
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Sep 11, 2018
@gundalow gundalow merged commit 4264be2 into ansible:devel Sep 11, 2018
@acozine acozine mentioned this pull request Sep 13, 2018
Merged
@acozine acozine deleted the whack-an-error branch September 13, 2018 19:30
@acozine acozine moved this from To do to Backport to 2.7 in OLD Ansible Documentation Sep 17, 2018
@samccann samccann mentioned this pull request Sep 19, 2018
Merged
@acozine acozine moved this from Backport to 2.7 to Done in OLD Ansible Documentation Sep 20, 2018
@acozine acozine mentioned this pull request Sep 28, 2018
Merged
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

@samccann samccann samccann approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
No open projects
OLD Ansible Documentation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@acozine @ansibot @gundalow @samccann