-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add key_data argument to ec2_win_password.py module #45463
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The key_data argument helps when using a private key stored in Vault.
Hi @maxstack, Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for aws. |
ansibot
added
affects_2.8
This issue/PR affects Ansible v2.8
aws
cloud
community_review
In order to be merged, this PR must follow the community review workflow.
feature
This issue/PR relates to a feature request.
module
This issue/PR relates to a module.
needs_triage
Needs a first human triage before being processed.
new_contributor
This PR is the first contribution by a new community member.
support:community
This issue/PR relates to code supported by the Ansible community.
labels
Sep 11, 2018
maxstack
changed the title
add key_data argument
add key_data argument to ec2_win_password.py module
Sep 11, 2018
Add version_added line to pass automated tests.
webknjaz
removed
the
needs_triage
Needs a first human triage before being processed.
label
Sep 11, 2018
s-hertel
approved these changes
Sep 12, 2018
ansibot
added
core_review
In order to be merged, this PR must follow the core review workflow.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
and removed
community_review
In order to be merged, this PR must follow the community review workflow.
support:community
This issue/PR relates to code supported by the Ansible community.
labels
Sep 19, 2018
ansibot
added
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
Sep 28, 2018
ansibot
added
community_review
In order to be merged, this PR must follow the community review workflow.
needs_maintainer
Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml)
support:community
This issue/PR relates to code supported by the Ansible community.
and removed
core_review
In order to be merged, this PR must follow the core review workflow.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
labels
Oct 6, 2018
ryansb
approved these changes
Oct 17, 2018
Tomorrow9
pushed a commit
to Tomorrow9/ansible
that referenced
this pull request
Dec 4, 2018
* add key_data argument The key_data argument helps when using a private key stored in Vault. * Add "version_added" line Add version_added line to pass automated tests. * remove unnecessary nesting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.8
This issue/PR affects Ansible v2.8
aws
cloud
community_review
In order to be merged, this PR must follow the community review workflow.
feature
This issue/PR relates to a feature request.
module
This issue/PR relates to a module.
needs_maintainer
Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml)
new_contributor
This PR is the first contribution by a new community member.
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
support:community
This issue/PR relates to code supported by the Ansible community.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key_data argument helps when using a private key stored in Vault.
SUMMARY
This PR relates to the AWS ec2_win_password.py module. We have a use case where we need to decrypt Windows passwords for ec2 instances, the existing module allows you to specify a file path to a private key. Our workspace is not persistent so the private key is not persistent to the filesystem, and we will not store it in SCM as Ansible Vault will not decrypt it on the fly.
I have added a new argument - key_data, to use as an alternative to key_file. You can store your private key in Ansible Vault and pass the variable (eg. "{{ ec2_private_key }}") to this argument for on the fly decryption.
ISSUE TYPE
COMPONENT NAME
ec2_win_password.py
ANSIBLE VERSION
ADDITIONAL INFORMATION