Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated documentation in vmware_guest.py #45481

Merged
merged 1 commit into from
Sep 17, 2018
Merged

updated documentation in vmware_guest.py #45481

merged 1 commit into from
Sep 17, 2018

Conversation

toxicvengeance
Copy link
Contributor

SUMMARY

Added note regarding online disk resizing and changed wording of a few sentences. Also added vSphere 6.7 as "tested on" as it works very well and I use it on a daily basis for deploying and modifying virtual machines.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

vmware_guest.py

ANSIBLE VERSION
ansible 2.6.4
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/dist-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.12 (default, Dec  4 2017, 14:50:18) [GCC 5.4.0 20160609]

Added note regarding online disk resizing and changed wording of a few sentences. Also added vSphere 6.7 as "tested on" as it works very well.
@ansibot
Copy link
Contributor

ansibot commented Sep 11, 2018

@ansibot
Copy link
Contributor

ansibot commented Sep 11, 2018

Hi @toxicvengeance,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Sep 11, 2018
@webknjaz webknjaz removed the needs_triage Needs a first human triage before being processed. label Sep 11, 2018
@mscherer
Copy link
Contributor

shipit

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 16, 2018
@samccann
Copy link
Contributor

Thanks @toxicvengeance for helping to improve the Ansible documentation!

@samccann samccann merged commit 05840ff into ansible:devel Sep 17, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cloud core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. vmware VMware community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants