Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uneeded global declaration of variable warnings #45653

Merged
merged 1 commit into from
Sep 14, 2018
Merged

Remove uneeded global declaration of variable warnings #45653

merged 1 commit into from
Sep 14, 2018

Conversation

mscherer
Copy link
Contributor

SUMMARY

Remove uneeded global declaration of variable warnings

Since the variable is used only once, no need to declare it global.
Remove a warning from linter (lgtm.com)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

voss_facts

@ansibot
Copy link
Contributor

ansibot commented Sep 14, 2018

cc @LindsayHill @bigmstone
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 14, 2018

Hi @mscherer,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 14, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 14, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/voss/voss_facts.py:446:1: E303 too many blank lines (3)

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 14, 2018
@mscherer
Remove uneeded global declaration of variable warnings
6b53e8e 
Since the variable is used only once, no need to declare it global.
Remove a warning from linter (lgtm.com)
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 14, 2018
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Sep 14, 2018
@s-hertel
Copy link
Contributor

Thanks for these. FYI - would be nice if these were folded into more meaningful changes.

@s-hertel s-hertel merged commit a1e2f1b into ansible:devel Sep 14, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mscherer @ansibot @s-hertel