Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.6] ec2_group: fix regression for targets that are a list containing strings and lists #45748

Merged
merged 3 commits into from
Sep 25, 2018

Conversation

s-hertel
Copy link
Contributor

@s-hertel s-hertel commented Sep 17, 2018

SUMMARY

Backport #45594

ec2_group: fix regression for targets that are a list containing strings and lists (#45594)

  • Fix targets that may be a list containing strings and lists which worked prior to 2.6.

  • Add ec2_group integration tests for lists of nested targets

  • changelog

Cherry-picked the fix, the tests, and the changelog. I did not cherry-pick the commit fixing this for diff mode as it can only be backported to 2.7.

(cherry picked from commit 450fb9f)
(cherry picked from commit 14e3399)
(cherry picked from commit fb17db0)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_group

ANSIBLE VERSION
2.6

@ansibot
Copy link
Contributor

ansibot commented Sep 17, 2018

cc @adq
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 17, 2018

Hi @s-hertel,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 aws backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 17, 2018
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Sep 17, 2018
@mattclay mattclay merged commit 0be82f2 into ansible:stable-2.6 Sep 25, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.6 This issue/PR affects Ansible v2.6 aws backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants