Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.6] docker_container: don't parse/interpret options if state is 'absent' #45768

Merged
merged 2 commits into from
Sep 25, 2018
Merged

[2.6] docker_container: don't parse/interpret options if state is 'absent' #45768

merged 2 commits into from
Sep 25, 2018

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Backport of #45700 to stable-2.6: don't parse and/or interpret options (ports, networks, IP addresses, ...) when state is 'absent' (fixed #45486).

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_container

ANSIBLE VERSION
2.6.4

@ansibot
Copy link
Contributor

ansibot commented Sep 18, 2018

cc @chouseknecht @cove @dusdanig @joshuaconner @kassiansun @softzilla @zfil
click here for bot help

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. docker module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 18, 2018
@kassiansun
Copy link
Contributor

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. labels Sep 18, 2018
@felixfontein felixfontein mentioned this pull request Sep 24, 2018
Closed
felixfontein added a commit to felixfontein/ansible that referenced this pull request Sep 24, 2018
@felixfontein
Remove regression test for fix which is in another backport PR (ansib…
6d3c0ba 
…le#45768).
@felixfontein felixfontein mentioned this pull request Sep 24, 2018
Merged
@mattclay mattclay merged commit fe2c9cd into ansible:stable-2.6 Sep 25, 2018
@felixfontein felixfontein deleted the backport/2.6/45700 branch September 26, 2018 04:28
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud docker module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felixfontein @ansibot @kassiansun @mattclay