[2.6] docker_container: fix various idempotency problems and non-working options #46058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* First round of integration tests for docker_container. * Added regression test for ansible#45700. * Work around dict order randomization.
ansibot
added
affects_2.6
…tions (ansible#45905) * Sorting args. * Doing comparisons of options with container parameters in a more context-sensitive way. This prevents unnecessary restarts, or missing restarts (f.ex. if parameters are removed from ``cmd``). * Make blkio_weight work. * Fix cap_drop idempotency problem. * Making groups idempotent if it contains integers. * Make cpuset_mems work. * Make dns_opts work. * Fixing log_opts: docker expects string values, returns error for integer. * Adding tests from felixfontein/ansible-docker_container-test#2. * Make uts work. * Adding changelog entry. * Forgot option security_opts. * Fixing typo. * Explain strict set(dict) comparison a bit more. * Improving idempotency tests. * Making dns_servers a list, since the ordering is relevant. * Making dns_search_domains a list, since the ordering is relevant. * Improving dns_search_domains/dns_servers. * Fixing entrypoint test. * Making sure options are only supported for correct docker-py versions.
felixfontein
force-pushed
the
backport/2.6/45905-45747
branch
from
78d4088
to
f3a2d22
Compare
ansibot
added
needs_ci
ansibot
removed
needs_ci
webknjaz
removed
needs_triage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is a backport of #45905 to
stable-2.7. It fixes various problems with idempotency and fixes some non-working options. It also includes basic idempotency tests for all options which modify container state. This PR also integrates #45747, which adds integration tests fordocker_containerin the first place (@gundalow suggested on IRC to include it with the backport PRs).Note: there will be a merge conflict once #45768 is merged (or vice versa), since code was added at the same position. I can rebase once one of the PRs has been merged.
ISSUE TYPE
COMPONENT NAME
docker_container
ANSIBLE VERSION