ec2_group - fix VPC precedence for security group targets #45787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the dictionary with the preferred values last to get the right order of VPC precedence Fixes ansible#45782
|
Hi @s-hertel, Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for aws. |
ansibot
added
affects_2.8
s-hertel
removed
the
needs_triage
s-hertel
commented
Sep 18, 2018
| @@ -855,6 +855,9 @@ def group_exists(client, module, vpc_id, group_id, name): | |||
| if security_groups: | |||
| groups = dict((group['GroupId'], group) for group in all_groups) | |||
| groups.update(dict((group['GroupName'], group) for group in all_groups)) | |||
| if vpc_id: | |||
There was a problem hiding this comment.
The VPC is used to filter above - but it doesn't only return results matching the VPC, it returns matches that meet at least one of the filters.
ryansb
approved these changes
Sep 18, 2018
s-hertel
added a commit
to s-hertel/ansible
that referenced
this pull request
Sep 18, 2018
) Update the dictionary with the preferred values last to get the right order of VPC precedence Fixes ansible#45782 (cherry picked from commit 8d2df9b)
s-hertel
added a commit
to s-hertel/ansible
that referenced
this pull request
Sep 18, 2018
) Update the dictionary with the preferred values last to get the right order of VPC precedence Fixes ansible#45782 (cherry picked from commit 8d2df9b)
This was referenced Sep 18, 2018
mattclay
pushed a commit
that referenced
this pull request
Sep 25, 2018
abadger
pushed a commit
that referenced
this pull request
Oct 9, 2018
…) (#45815) * ec2_group - fix VPC precedence for security group targets (#45787) Update the dictionary with the preferred values last to get the right order of VPC precedence Fixes #45782 (cherry picked from commit 8d2df9b) * Fix ec2_group for EC2-Classic accounts (#46242) * Fix ec2_group for EC2-Classic accounts * changelog (cherry picked from commit 9efc3dc) * Merge changelogs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Update the dictionary with the preferred values last to get the right order of VPC precedence
Fixes #45782
This should be backported to 2.6 and 2.7.
ISSUE TYPE
COMPONENT NAME
ec2_group
ANSIBLE VERSION