Update eos_config.py #45810
Merged
Update eos_config.py #45810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches will accept the previously used syntax for /32 ACL entries, but they get changed to host ipaddress in the config file. This results in the config check failing every time (permit ip 1.1.1.1/32 any log != permit ip host 1.1.1.1 any log), resulting in the ACL getting re-created on every single run of the Playbook. Making this proposed change to the example will make it work in an idempotent manner. +label: docsite_pr
|
Hi @cordones, Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for network. |
ansibot
added
affects_2.8
jborean93
removed
the
needs_triage
ansibot
removed
the
new_contributor
dagwieers
added
the
docsite_pr
ansibot
added
the
stale_ci
ansibot
added
support:network
|
Thanks @cordones for improving the eos example! |
Tomorrow9
pushed a commit
to Tomorrow9/ansible
that referenced
this pull request
Dec 4, 2018
Switches will accept the previously used syntax for /32 ACL entries, but they get changed to host ipaddress in the config file. This results in the config check failing every time (permit ip 1.1.1.1/32 any log != permit ip host 1.1.1.1 any log), resulting in the ACL getting re-created on every single run of the Playbook. Making this proposed change to the example will make it work in an idempotent manner. +label: docsite_pr
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches will accept the previously used syntax for /32 ACL entries, but they get changed to host ipaddress in the config file.
This results in the config check failing every time (permit ip 1.1.1.1/32 any log != permit ip host 1.1.1.1 any log), resulting in the ACL getting re-created on every single run of the Playbook.
Making this proposed change to the example will make it work in an idempotent manner.
+label: docsite_pr
SUMMARY
ISSUE TYPE
COMPONENT NAME
ANSIBLE VERSION
ADDITIONAL INFORMATION