Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ospf net type #45904

Merged
merged 3 commits into from
Sep 25, 2018
Merged

Add ospf net type #45904

merged 3 commits into from
Sep 25, 2018

Conversation

dmurarasu
Copy link
Contributor

SUMMARY

Adding option to configure interface network type using nxos_interface_ospf module

Fixes #45901

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

nxos_interface_ospf

ANSIBLE VERSION
ansible 2.8.0.dev0 (devel 6e04a1dbdc) last updated 2018/09/19 11:40:47 (GMT +000)
  config file = None
  configured module search path = [u'/home/vagrant/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/vagrant/ansible/lib/ansible
  executable location = /home/vagrant/ansible/bin/ansible
  python version = 2.7.12 (default, Dec  4 2017, 14:50:18) [GCC 5.4.0 20160609]
ADDITIONAL INFORMATION

This PR adds extra network parameter mentioned in #45901
Tested on 93180YC-EX running NXOS: version 7.0(3)I6(1)
Added documentation and test cases as well.

@dmurarasu dmurarasu mentioned this pull request Sep 20, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Sep 20, 2018

cc @NilashishC @Qalthos @ganeshrn @gdpak @justjais @mikewiebe @rahushen @rcarrillocruz @trishnaguha @tstoner
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 20, 2018

Hi @dmurarasu,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Sep 20, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 20, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/nxos/nxos_interface_ospf.py:0:0: E309 version_added for new option (network) should be 2.8. Currently 0.0

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 20, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 20, 2018
@trishnaguha trishnaguha self-assigned this Sep 21, 2018
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label Sep 21, 2018
@trishnaguha trishnaguha merged commit a6c2048 into ansible:devel Sep 25, 2018
@trishnaguha
Copy link
Member

Thanks for the PR.

@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
affects_2.8 This issue/PR affects Ansible v2.8 cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. networking Network category new_contributor This PR is the first contribution by a new community member. nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nxos_interface_ospf - add ospf network type option
4 participants
@dmurarasu @ansibot @trishnaguha @dagwieers