powershell - fix for ANSIBLE_KEEP_REMOTE_FILES on older Pythons #45942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitzmahone
approved these changes
Sep 20, 2018
ansibot
added
affects_2.8
|
Test failure is unrelated to the changes made. |
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
Sep 21, 2018
…ble#45942) (cherry picked from commit ce515a6)
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
Sep 21, 2018
…ble#45942) (cherry picked from commit ce515a6)
This was referenced Sep 21, 2018
mattclay
pushed a commit
that referenced
this pull request
Sep 25, 2018
(cherry picked from commit ce515a6)
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
Sep 27, 2018
…ns (ansible#45942)" This reverts commit ce515a6.
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
Sep 27, 2018
…ns (ansible#45942)" (ansible#46238) This reverts commit ce515a6.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
As stated by https://docs.python.org/2/library/shlex.html
This change makes sure the command passed into the PowerShell command builder is a native (byte string) on Python 2.x and a unicode string on Python 3.x. This fits the support statement for shlex and ensures the output command is valid.
Fixes #45490
ISSUE TYPE
COMPONENT NAME
powershell
ANSIBLE VERSION