Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

powershell - fix for ANSIBLE_KEEP_REMOTE_FILES on older Pythons #45942

Merged
merged 1 commit into from
Sep 21, 2018
Merged

powershell - fix for ANSIBLE_KEEP_REMOTE_FILES on older Pythons #45942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/win_keep_remote_file_python26.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- powershell - Fix issue where setting ANSIBLE_KEEP_REMOTE_FILES fails when using Python 2.6 - https://github.com/ansible/ansible/issues/45490
4 changes: 2 additions & 2 deletions lib/ansible/plugins/shell/powershell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
import shlex

from ansible.errors import AnsibleError
from ansible.module_utils._text import to_text
from ansible.module_utils._text import to_native, to_text
from ansible.plugins.shell import ShellBase


Expand Down Expand Up @@ -1605,7 +1605,7 @@ def build_module_command(self, env_string, shebang, cmd, arg_path=None):

# non-pipelining

cmd_parts = shlex.split(cmd, posix=False)
cmd_parts = shlex.split(to_native(cmd), posix=False)
cmd_parts = list(map(to_text, cmd_parts))
if shebang and shebang.lower() == '#!powershell':
if not self._unquote(cmd_parts[0]).lower().endswith('.ps1'):
Expand Down