Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fortinet FortiManager Device Config Module #46080

Merged
merged 6 commits into from
Nov 21, 2018
Merged

Fortinet FortiManager Device Config Module #46080

merged 6 commits into from
Nov 21, 2018

Conversation

ftntcorecse
Copy link
Contributor

SUMMARY

Allows users to change various device settings on registered FortiManager devices such as a FortiGate. For now basic functionality allows for hostname and interface changes.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

fmgr_device_config.py
test_fmgr_device_config.py
fixtures/test_fmgr_device_config.json

ANSIBLE VERSION
ansible 2.4.3.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/usr/ansible_modules']
  ansible python module location = /usr/local/lib/python2.7/dist-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.12 (default, Dec  4 2017, 14:50:18) [GCC 5.4.0 20160609]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Sep 24, 2018

cc @NilashishC @Qalthos @ganeshrn @gdpak @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 24, 2018

Hi @ftntcorecse,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Sep 24, 2018
@webknjaz webknjaz removed the needs_triage Needs a first human triage before being processed. label Sep 25, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 3, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 12, 2018
@ftntcorecse
Copy link
Contributor Author

@samccann -- and another one. Thanks!

samccann
samccann approved these changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from a docs perspective.

@ansibot
Copy link
Contributor

ansibot commented Nov 20, 2018

cc @ftntcorecse @Ghilli3 @lweighall @p4r4n0y1ng
click here for bot help

@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Nov 21, 2018
@NilashishC
Copy link
Contributor

LGTM

@NilashishC NilashishC merged commit 050a2c5 into ansible:devel Nov 21, 2018
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@ftntcorecse @mjmayer
Fortinet FortiManager Device Config Module (ansible#46080)
d586b93 
* fmgr_device_config PR candidate

* fmgr_fwobj_address PR candidate

* PR candidate

* Resolving Edits

* Resolving Edits

* Fixing Authors
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@ftntcorecse @Tomorrow9
Fortinet FortiManager Device Config Module (ansible#46080)
3ede3cb 
* fmgr_device_config PR candidate

* fmgr_fwobj_address PR candidate

* PR candidate

* Resolving Edits

* Resolving Edits

* Fixing Authors
@ftntcorecse ftntcorecse deleted the fmgr_device_config branch February 21, 2019 04:24
@dagwieers dagwieers added the fortimanager Fortimanager community label Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NilashishC NilashishC NilashishC approved these changes

@samccann samccann samccann approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. fortimanager Fortimanager community module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ftntcorecse @ansibot @NilashishC @samccann @dagwieers @webknjaz @lweighall