Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made sros_config docs match code for match options #46135

Merged
merged 2 commits into from
Sep 26, 2018
Merged

made sros_config docs match code for match options #46135

merged 2 commits into from
Sep 26, 2018

Conversation

samccann
Copy link
Contributor

SUMMARY

Make the sros_config documentation match the code, which limits 'match' to line or none.

Fixes #22825

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

sros_config

ANSIBLE VERSION
2.8
ADDITIONAL INFORMATION

@samccann samccann added networking Network category docs This issue/PR relates to or includes documentation. labels Sep 25, 2018
@samccann samccann added this to Docsite work in Ansible-maintained Collections Documentation via automation Sep 25, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 25, 2018

cc @privateip
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 25, 2018

Hi @samccann,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Sep 25, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 25, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

test/sanity/validate-modules/ignore.txt:914:1: A102 Remove since "lib/ansible/modules/network/sros/sros_config.py" passes "E326" test

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 25, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 25, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 25, 2018

cc @mattclay
click here for bot help

@ansibot ansibot added test This PR relates to tests. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Sep 25, 2018
@gdpak gdpak merged commit 08c3924 into ansible:devel Sep 26, 2018
Ansible-maintained Collections Documentation automation moved this from Docsite work to Done Sep 26, 2018
@samccann samccann deleted the sros_config branch December 6, 2018 21:32
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow Awaiting requested review from gundalow

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
No open projects
Ansible-maintained Collections Docume...
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sros_config match behavior unclear
3 participants
@samccann @ansibot @gdpak