Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.7] route53: fix CAA record ordering for idempotency #46227

Merged
merged 2 commits into from
Oct 10, 2018
Merged

[2.7] route53: fix CAA record ordering for idempotency #46227

merged 2 commits into from
Oct 10, 2018

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Backport of #46049: fix CAA record ordering for idempotency in the route53 module.

Does not contain the integration tests added in #46049 per request of @ryansb.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

route53

ANSIBLE VERSION
2.7.0

@felixfontein
[aws] route53 module: fix idempotency for CAA records (ansible#46049)
28fa044 
* Fixing record order for CAA records to properly handle idempotency.

* Add integration tests that reproduce CAA failure

(cherry picked from commit a727a1e)
@ansibot
Copy link
Contributor

ansibot commented Sep 27, 2018

Hi @felixfontein,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 aws backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 27, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Sep 27, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. and removed core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 5, 2018
@abadger
Copy link
Contributor

abadger commented Oct 9, 2018

@felixfontein / @ryansb Could one of you add a changelog for this? Then it looks good for merging.

@felixfontein
Copy link
Contributor Author

I'll add one (also to the stable-2.6 backport).

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Oct 9, 2018
@felixfontein
Copy link
Contributor Author

bot_status

@ansibot
Copy link
Contributor

ansibot commented Oct 9, 2018

Components

changelogs/fragments/46049-route53-caa-ordering.txt
support: community
maintainers:

lib/ansible/modules/cloud/amazon/route53.py
support: community
maintainers:

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: blocked
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 1
shipit_actors (maintainers or core team members): felixfontein
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 9, 2018
@abadger abadger merged commit c481a5b into ansible:stable-2.7 Oct 10, 2018
@abadger
Copy link
Contributor

abadger commented Oct 10, 2018

Merged for the 2.7.1 release

@felixfontein felixfontein deleted the backport/2.7/46049 branch October 10, 2018 05:05
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 aws backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@felixfontein @ansibot @abadger @ryansb @samdoran