VMware: Improve module vmware_host_config_manager

[ckotte]

SUMMARY

The module doesn't execute in check mode and you cannot see if the settings need to be changed. You also cannot see which settings were changed or need to be changed if you run the play in verbose mode.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

vmware_host_config_manager

ANSIBLE VERSION

# ansible --version
ansible 2.6.3
  config file = /root/ansible-vmware/ansible.cfg
  configured module search path = [u'/root/ansible-vmware/library']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, Jul 13 2018, 13:06:57) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]

ADDITIONAL INFORMATION

before (check mode):
TASK [esxi : Configure persistent logs (Syslog)] *********************************************************************************************************************************************************************************************
before:

TASK [esxi : Configure persistent logs (Syslog)] *********************************************************************************************************************************************************************************************
changed: [esxi_host -> jump_server] => {"changed"}

after (check mode):

TASK [esxi : Configure persistent logs (Syslog)] *********************************************************************************************************************************************************************************************
changed: [esxi_host -> jump_server] => {"changed": true, "msg": "Syslog.global.logDirUnique, Syslog.global.defaultRotate, and Syslog.global.defaultSize would be changed."}

after:

TASK [esxi : Configure persistent logs (Syslog)] *********************************************************************************************************************************************************************************************
changed: [esxi_host -> jump_server] => {"changed": true, "msg": "Syslog.global.logDirUnique, Syslog.global.defaultRotate, and Syslog.global.defaultSize changed."}

[ansibot]

cc @Akasurde @dav1x @warthog9
click here for bot help

[ansibot]

Hi @ckotte,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

[Akasurde]

Code LGTM. Could you please add test case for this change ?

[ckotte]

@Akasurde Could you please explain to me what test case I need to add? I only added "supports_check_mode=True", changed the code to not do any changes in check mode, and improved the change message.

[Akasurde]

@ckotte Thanks for the contribution.