Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lambda: fix unboundLocalError in lambda #46729

Merged
merged 1 commit into from
Oct 10, 2018
Merged

lambda: fix unboundLocalError in lambda #46729

merged 1 commit into from
Oct 10, 2018

Conversation

Akasurde
Copy link
Member

SUMMARY

This fix initializes current_version to None so that
module proceeds in check mode.

Fixes: #46654

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/amazon/lambda.py

ANSIBLE VERSION
2.8-devel

@Akasurde
lambda: fix unboundLocalError in lambda
981e077 
This fix initializes current_version to None so that
module proceeds in check mode.

Fixes: ansible#46654

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented Oct 10, 2018

Hi @Akasurde,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 aws bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Oct 10, 2018
@ryansb ryansb removed the needs_triage Needs a first human triage before being processed. label Oct 10, 2018
@Akasurde Akasurde merged commit 3239753 into ansible:devel Oct 10, 2018
@Akasurde Akasurde deleted the i46654 branch October 10, 2018 17:28
@Akasurde
Copy link
Member Author

@ryansb Thanks for the review.

Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@Akasurde @Tomorrow9
lambda: fix unboundLocalError in lambda (ansible#46729)
40b742a 
This fix initializes current_version to None so that
module proceeds in check mode.

Fixes: ansible#46654

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 aws bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lambda: UnboundLocalError: local variable 'current_version' referenced before assignment
3 participants
@Akasurde @ansibot @ryansb