Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: New module vmware_host_ipv6 #47275

Merged
merged 2 commits into from
Oct 19, 2018
Merged

VMware: New module vmware_host_ipv6 #47275

merged 2 commits into from
Oct 19, 2018

Conversation

ckotte
Copy link
Contributor

@ckotte ckotte commented Oct 18, 2018

SUMMARY

New module to control IPv6 support for an ESXi host. You might be able to set this with an advanced setting as well, but the module checks if it's really enabled/disabled and if a restart is required.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

vmware_host_ipv6

ANSIBLE VERSION
ansible 2.6.3
  config file = /root/ansible-vmware/ansible.cfg
  configured module search path = [u'/root/ansible-vmware/library']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, Jul 13 2018, 13:06:57) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Oct 18, 2018

Hi @ckotte, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 18, 2018

cc @Akasurde @dav1x @warthog9
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 18, 2018

@ckotte, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Oct 18, 2018
@ckotte ckotte force-pushed the vmware_host_ipv6 branch 2 times, most recently from dee06ab to 3cb7a86 Compare October 18, 2018 12:04
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Oct 18, 2018
@ansibot
Copy link
Contributor

ansibot commented Oct 18, 2018

@MikeKlebolt @Akasurde @bedecarroll @CastawayEGR @chrrrles @dav1x @garbled1 @imjoseangel @jjahns @kamsz @kryptsi @lrivallain @nafpliot-ibm @nerzhul @oboukili @pdellaert @rhoop @ritzk @rmin @stravassac @tchernomax @warthog9 @woshihaoren

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 18, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Oct 18, 2018
Akasurde
Akasurde requested changes Oct 19, 2018
View reviewed changes
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

lib/ansible/modules/cloud/vmware/vmware_host_ipv6.py Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/vmware/vmware_host_ipv6.py Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/vmware/vmware_host_ipv6.py Outdated Show resolved Hide resolved
test/integration/targets/vmware_host_ipv6/tasks/main.yml Outdated Show resolved Hide resolved
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Oct 19, 2018
@ansibot
Copy link
Contributor

ansibot commented Oct 19, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_host_ipv6.py:133:65: E126 continuation line over-indented for hanging indent

click here for bot help

@ckotte ckotte force-pushed the vmware_host_ipv6 branch 3 times, most recently from 6f178ef to 305baad Compare October 19, 2018 11:26
@Akasurde Akasurde changed the title WMware: New module vmware_host_ipv6 VMware: New module vmware_host_ipv6 Oct 19, 2018
@ansibot
Copy link
Contributor

ansibot commented Oct 19, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

lib/ansible/modules/cloud/vmware/vmware_host_ipv6.py:0:0: E322 "state" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/vmware/vmware_host_ipv6.py:0:0: E323 "enabled" is listed in DOCUMENTATION.options, but not accepted by the module
lib/ansible/modules/cloud/vmware/vmware_host_ipv6.py:0:0: E324 Value for "default" from the argument_spec ('enabled') for "state" does not match the documentation (None)
lib/ansible/modules/cloud/vmware/vmware_host_ipv6.py:0:0: E326 Value for "choices" from the argument_spec (['enabled', 'disabled']) for "state" does not match the documentation ([])

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Oct 19, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Oct 19, 2018
@ckotte ckotte force-pushed the vmware_host_ipv6 branch 2 times, most recently from 7f849a1 to e342f55 Compare October 19, 2018 16:36
@Akasurde
Minor changes
e047357 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde merged commit cd988f6 into ansible:devel Oct 19, 2018
@Akasurde
Copy link
Member

@ckotte Thanks for the contribution.

@ckotte
Copy link
Contributor Author

ckotte commented Oct 19, 2018

@Akasurde Just wanted to push another change. type: bool needs to be changed to type: str.

@ckotte
Copy link
Contributor Author

ckotte commented Oct 19, 2018

Is there a way to put that PR on hold without adding WIP?

@Akasurde
Copy link
Member

@ckotte I'm sorry, I thought all changes were made so merge it. There is no another way (other than WIP) to put PR on hold.

@Akasurde
Copy link
Member

@ckotte #47362

@ckotte
Copy link
Contributor Author

ckotte commented Oct 19, 2018 •
edited

@ckotte #47362

thx

Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@ckotte @Tomorrow9
VMware: New module vmware_host_ipv6 (ansible#47275)
f0e7b6a 
* New module vmware_host_ipv6
* Minor changes

Signed-off-by: Christian Kotte <christian.kotte@gmx.de>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cloud module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ckotte @ansibot @Akasurde @samdoran