Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: Add check mode support to vmware_vmkernel_facts #47286

Merged
merged 1 commit into from Oct 19, 2018
Merged

VMware: Add check mode support to vmware_vmkernel_facts #47286

merged 1 commit into from Oct 19, 2018

Conversation

ckotte
Copy link
Contributor

@ckotte ckotte commented Oct 18, 2018

SUMMARY

Add check mode support.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_vmkernel_facts

ANSIBLE VERSION
ansible 2.6.3
  config file = /root/ansible-vmware/ansible.cfg
  configured module search path = [u'/root/ansible-vmware/library']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, Jul 13 2018, 13:06:57) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Oct 18, 2018

Hi @ckotte, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 18, 2018

cc @Akasurde @dav1x @warthog9
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 18, 2018

@ckotte, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Oct 18, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Oct 18, 2018
@Akasurde
Copy link
Member

@ckotte Thanks for the PR. Could you please add integration test for this change ? I am aware that vcsim does not support vmkernel facts, but it would be nice to have this test case. Thanks.

@ckotte
Copy link
Contributor Author

ckotte commented Oct 19, 2018

@ckotte Thanks for the PR. Could you please add integration test for this change ? I am aware that vcsim does not support vmkernel facts, but it would be nice to have this test case. Thanks.

Ok. I added check mode test.

@Akasurde Akasurde merged commit dc2eb05 into ansible:devel Oct 19, 2018
@Akasurde
Copy link
Member

@ckotte Thanks for the contribution.

Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@ckotte @Tomorrow9
VMware: Add check mode support to vmware_vmkernel_facts (ansible#47286)
bc6b10b
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. small_patch support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ckotte @ansibot @Akasurde @samdoran