Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix webapp test #47546

Merged
merged 3 commits into from
Oct 25, 2018
Merged

fix webapp test #47546

merged 3 commits into from
Oct 25, 2018

Conversation

yungezz
Copy link
Contributor

@yungezz yungezz commented Oct 24, 2018 •
edited

SUMMARY

Fix webapp test, VSChina/ansible-issue-tracker#524

  1. failed to get key 'id' when create app service plan. Use explicit object to dict instead of as_dict
  2. remove unstable tag
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ANSIBLE VERSION
ansible 2.8
ADDITIONAL INFORMATION

zikalino
zikalino reviewed Oct 24, 2018
View reviewed changes
packaging/requirements/requirements-azure.txt
@@ -4,7 +4,7 @@ azure-cli-core==2.0.35
azure-cli-nspkg==3.0.2
azure-common==1.1.11
azure-mgmt-batch==4.1.0
azure.mgmt.cdn==3.0.0
azure-mgmt-cdn==3.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so is it really necessary? as it somehow worked with broken requirement....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it's necessary to do right thing. actually i didn't understand why previous version works :(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so are you sure we need this dependency?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, perhaps correct version is in test requirements..... but then sanity tests wouldn't pass....

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I think you also need to update in test/runner/requirements

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch. fixed. the dependency is for cdn.

@ansibot
Copy link
Contributor

ansibot commented Oct 24, 2018

Hi @yungezz, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 24, 2018

cc @haroldwongms @nitzmahone @trstringer @xscript @yuwzho @zikalino
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 24, 2018

@yungezz, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 azure bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 24, 2018
@ansibot
Copy link
Contributor

ansibot commented Oct 24, 2018

cc @mattclay
click here for bot help

@ansibot ansibot added the test This PR relates to tests. label Oct 24, 2018
@yungezz yungezz merged commit 1587bb9 into ansible:devel Oct 25, 2018
@yungezz yungezz deleted the webapp-test branch October 25, 2018 01:45
@yungezz yungezz mentioned this pull request Oct 25, 2018
Closed
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@yungezz @Tomorrow9
fix webapp test (ansible#47546)
98a7a08
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zikalino zikalino zikalino approved these changes

@mattclay mattclay Awaiting requested review from mattclay

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 azure bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yungezz @ansibot @zikalino