Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better description for the ce_vlan module #47816

Merged
merged 1 commit into from Oct 30, 2018
Merged

Conversation

wilmardo
Copy link
Contributor

SUMMARY

Description for the name and description was vague. I didn't get the first time reading that it was talking about a character limit more a range of 1-80 in numbers. Which doesn't make sense for a name :)

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

ce_vlan

ANSIBLE VERSION
2.7.1

Description for the name and description was vague. I didn't get the first time reading that it was talking about a character limit.

+label: docsite_pr
@ansibot
Copy link
Contributor

ansibot commented Oct 30, 2018

Hi @wilmardo, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 30, 2018

@ansibot
Copy link
Contributor

ansibot commented Oct 30, 2018

@wilmardo, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Oct 30, 2018
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement, thank you :)

@acozine acozine merged commit 7e9141e into ansible:devel Oct 30, 2018
gundalow pushed a commit to gundalow/ansible that referenced this pull request Oct 30, 2018
Description for the name and description was vague. I didn't get the first time reading that it was talking about a character limit.

+label: docsite_pr
(cherry picked from commit 7e9141e)
@gundalow
Copy link
Contributor

Backported in #47819

acozine pushed a commit that referenced this pull request Oct 30, 2018
Description for the name and description was vague. I didn't get the first time reading that it was talking about a character limit.
(cherry picked from commit 7e9141e)
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Nov 1, 2018
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
Description for the name and description was vague. I didn't get the first time reading that it was talking about a character limit.

+label: docsite_pr
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. networking Network category new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants