Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: Remove unused option from vmware_host_datastore #47824

Merged
merged 1 commit into from Nov 14, 2018
Merged

VMware: Remove unused option from vmware_host_datastore #47824

merged 1 commit into from Nov 14, 2018

Conversation

ckotte
Copy link
Contributor

@ckotte ckotte commented Oct 30, 2018 •
edited

SUMMARY

Datacenter name isn't used, but it's a required option. It should be removed (in 2.11).

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_host_datastore

ANSIBLE VERSION
2.8-devel
ADDITIONAL INFORMATION

@ckotte ckotte force-pushed the vmware_host_datastore branch 2 times, most recently from a29c2c4 to 20da0b3 Compare October 30, 2018 17:01
@ckotte
Remove datacenter_name option from vmware_host_datastore
9582f60 
The datacenter name isn't required to create a NFS or VMFS datastore.
The option isn't available in the spec.
@ansibot
Copy link
Contributor

ansibot commented Oct 30, 2018

Hi @ckotte, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 30, 2018

cc @Akasurde @dav1x @warthog9
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 30, 2018

@ckotte, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Oct 30, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Nov 1, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 9, 2018
@Akasurde
Copy link
Member

rebuild_merge

@ansibot ansibot added owner_pr This PR is made by the module's maintainer. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Nov 14, 2018
@ansibot ansibot merged commit b964c46 into ansible:devel Nov 14, 2018
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@ckotte @mjmayer
Remove datacenter_name option from vmware_host_datastore (ansible#47824)
842d03f 
The datacenter name isn't required to create a NFS or VMFS datastore.
The option isn't available in the spec.
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@ckotte @Tomorrow9
Remove datacenter_name option from vmware_host_datastore (ansible#47824)
75598ef 
The datacenter name isn't required to create a NFS or VMFS datastore.
The option isn't available in the spec.
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ckotte @ansibot @Akasurde @jborean93