VMware: Improve module vmware_local_user_facts

[ckotte]

SUMMARY

• add check mode support
• add assigned role to the output
• change output to match vmware_local_user_manager output (PR VMware: Improve module vmware_local_user_manager #47866)
  • change principal to user_name
  • change full_name to user_description
  • change user_group to group
  • change user_description to description

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

vmware_local_user_facts

ANSIBLE VERSION

2.8-devel

ADDITIONAL INFORMATION

[ansibot]

Hi @ckotte, thank you for submitting this pull-request!

click here for bot help

[ansibot]

cc @Akasurde @dav1x @warthog9
click here for bot help

[ansibot]

@ckotte, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

[Akasurde]

We are changing facts keys here, we should add older values as well as new values. Because, removing old values will break playbooks and roles which are already written by user of this modules.
Ideally we should

1. Add a note in notes section stating these values will be deprecated after 4 versions.
2. Add a porting guide

Let me know if it makes sense.

[ckotte]

Isn't this a bit overkill? You couldn't assign roles to users before #47866. Anyway. How can you combine two lists without messing the whole output?

[Akasurde]

Yes, I understand it is a bit overkill, but consider from UX point of view. People already using this module will be surprised to see failing PB which were already working.

You can keep -

        {
            "full_name": "DCUI User",
            "principal": "dcui",
            "user_group": false,
            "role": "admin",
            "description": "DCUI User",
            "group": false,
            "user_id": 100,
            "user_shell_access": false
            "user_name": "dcui",
            "shell_access": false
        },

I aware that information is redundant but that will atleast not break playbooks. We will add porting guide note here and a note in documentation stating that these values will be deprecated after 4 release i.e. 2.12

[Akasurde]

I have added similar note in porting guide for vmware_local_role_facts here = https://github.com/ansible/ansible/blob/devel/docs/docsite/rst/porting_guides/porting_guide_2.8.rst#id12

[ckotte]

ok. I thought this is the PR with the dict to list change. I added the old names and notes.

[ckotte]

What do you want to write in the port guide? I think it's sufficient if we add a note later in 2.12 that the properties are deprecated.

[Akasurde]

@ckotte Thanks for the contribution.