Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix junos_command.py network module to support spaces in rpc args #48343

Merged
merged 2 commits into from
Nov 13, 2018

Conversation

vanyasvl
Copy link
Contributor

@vanyasvl vanyasvl commented Nov 8, 2018

SUMMARY

junos_command.py module doesn't support spaces in rpcs arguments.
This patch fixes it

ISSUE TYPE
  • BugFix Request
COMPONENT NAME
  • junos_command network module
ANSIBLE VERSION
ansible 2.7.1
  config file = /Users/sid/.ansible.cfg
  configured module search path = [u'/Users/sid/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.15 (default, Sep 18 2018, 20:30:39) [GCC 4.2.1 Compatible Apple LLVM 10.0.0 (clang-1000.10.43.1)]
ADDITIONAL INFORMATION

You should quote argument with spaces.
Example:

---
    - name: add license to device
      junos_command:
        rpcs: 
          - "request-license-add key-data='a a a'"

@ansibot
Copy link
Contributor

ansibot commented Nov 8, 2018

Hi @vanyasvl, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 8, 2018

@ansibot
Copy link
Contributor

ansibot commented Nov 8, 2018

@vanyasvl, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. small_patch support:network This issue/PR relates to code supported by the Ansible Network Team. labels Nov 8, 2018
@justjais justjais self-requested a review November 8, 2018 14:55
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Nov 8, 2018
@justjais justjais merged commit 80d57ec into ansible:devel Nov 13, 2018
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
…sible#48343)

* Fix junos_command.py network module to support spaces in rpc args

*  Fix junos_command.py network module to support spaces in rpc args
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
…sible#48343)

* Fix junos_command.py network module to support spaces in rpc args

*  Fix junos_command.py network module to support spaces in rpc args
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category new_contributor This PR is the first contribution by a new community member. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants