Add support for ECR Lifecycle Policies to ecs_ecr #48997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased #32137 |
sivel
changed the title
|
Hi @SpamapS, thank you for submitting this pull-request! |
ansibot
added
affects_2.8
|
The test |
ansibot
added
ci_verified
abadger
removed
needs_triage
ansibot
added
needs_rebase
ansibot
added
the
stale_ci
|
Would be most appreciated if this PR could be picked back up :) |
|
Rebased! I've had this vendored locally since the initial rebase I did... would be great to rejoin the fold in some future Ansible release. :) |
New feature for ecs_ecr to support [ECR Lifecycle Policies][]. Fixes ansible#32003 [ECR Lifecycle Policies]: https://docs.aws.amazon.com/AmazonECR/latest/userguide/LifecyclePolicies.html
Replaces the exception and stack trace with a description of what's actually going wrong from a user perspective.
Marks the `delete_policy` parameter as deprecated, to be removed in Ansible 2.6.
What I really want is --diff support, and changing results based on verbosity is abnormal.
The original PR sat while a few releases happened.
We missed the 2.8 release.
This is not allowed and is generally bad practice.
This was added in the time the PR has been in development, so rework things to use it.
This makes sure that lifecycle_policy is produced when passed in. *Also a minor suggestion for simplification from PR.
|
I believe that should do it, sanity and integration tests are passing locally. If CI passes and you don't have any objections to my changes there @SpamapS I'll give it a fresh set of eyes in the morning just to be safe but I think we should be about there. |
|
The test |
Per sanity test fail.
ansibot
added
core_review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add support for ECR Lifecycle Policies to ecs_ecr. Fixes #32003
ISSUE TYPE
COMPONENT NAME
ecs_ecr
ANSIBLE VERSION
ansible 2.4.0.0
config file = /Users/dlee/.ansible.cfg
configured module search path = [u'/Users/dlee/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
ansible python module location = /usr/local/Cellar/ansible/2.4.0.0/libexec/lib/python2.7/site-packages/ansible
executable location = /usr/local/bin/ansible
python version = 2.7.14 (default, Sep 25 2017, 09:53:22) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.37)]
ADDITIONAL INFORMATION
Integration tests provided, and they pass.
PLAY RECAP *********************************************************************
localhost : ok=55 changed=8 unreachable=0 failed=0